From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enric Balletbo i Serra Subject: Re: [PATCH 1/4] i2c: i2c-cros-ec-tunnel: Pass ACPI node to i2c adapter Date: Mon, 25 Nov 2019 17:06:26 +0100 Message-ID: <2dcedacb-8d08-6a58-23af-e834ef9e80fd@collabora.com> References: <20191121211053.48861-1-rrangel@chromium.org> <20191121140830.1.Iae79baaa31014e8b1d8177bcfbcd41514af724f9@changeid> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191121140830.1.Iae79baaa31014e8b1d8177bcfbcd41514af724f9@changeid> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Raul E Rangel , Wolfram Sang Cc: Akshu.Agrawal@amd.com, Guenter Roeck , Chanwoo Choi , linux-kernel@vger.kernel.org, Dmitry Torokhov , linux-i2c@vger.kernel.org, Benson Leung List-Id: linux-i2c@vger.kernel.org Hi, On 21/11/19 22:10, Raul E Rangel wrote: > The I2C bus needs to share the same ACPI node as the tunnel device so > that the I2C bus can be referenced from ACPI. > > Signed-off-by: Raul E Rangel Hmm, isn't this change the same as https://lkml.org/lkml/2019/11/21/208 ? Should I assume this deprecates the one pointed above? Who is the author? Please maintain the Signed-off chain. Thanks, Enric > --- > I would have added a Fixes annotation, but I wasn't able to find the > hash for https://lore.kernel.org/patchwork/patch/1151436/. > > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c > index 958161c71985..ac2412755f0a 100644 > --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c > +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c > @@ -272,6 +272,7 @@ static int ec_i2c_probe(struct platform_device *pdev) > bus->adap.algo_data = bus; > bus->adap.dev.parent = &pdev->dev; > bus->adap.dev.of_node = pdev->dev.of_node; > + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev)); > bus->adap.retries = I2C_MAX_RETRIES; > > err = i2c_add_adapter(&bus->adap); >