From: Hans de Goede <hdegoede@redhat.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: cht-wc: drop check because i2c_unregister_device() is NULL safe
Date: Wed, 4 Sep 2019 10:26:30 +0200 [thread overview]
Message-ID: <2e55f3cb-ba88-5404-3b38-585710976ed0@redhat.com> (raw)
In-Reply-To: <20190903175218.GE2171@ninjato>
Hi,
On 03-09-19 19:52, Wolfram Sang wrote:
> On Tue, Aug 20, 2019 at 05:34:40PM +0200, Wolfram Sang wrote:
>> No need to check the argument of i2c_unregister_device() because the
>> function itself does it.
>>
>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> ---
>
> Hans, are you OK with this change?
Yes this is fine by me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
>> Build tested only, buildbot is happy, too.
>>
>> Please apply to your tree.
>>
>> drivers/i2c/busses/i2c-cht-wc.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
>> index 66af44bfa67d..3e2608a65c06 100644
>> --- a/drivers/i2c/busses/i2c-cht-wc.c
>> +++ b/drivers/i2c/busses/i2c-cht-wc.c
>> @@ -363,8 +363,7 @@ static int cht_wc_i2c_adap_i2c_remove(struct platform_device *pdev)
>> {
>> struct cht_wc_i2c_adap *adap = platform_get_drvdata(pdev);
>>
>> - if (adap->client)
>> - i2c_unregister_device(adap->client);
>> + i2c_unregister_device(adap->client);
>> i2c_del_adapter(&adap->adapter);
>> irq_domain_remove(adap->irq_domain);
>>
>> --
>> 2.20.1
>>
next prev parent reply other threads:[~2019-09-04 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 15:34 [PATCH] i2c: cht-wc: drop check because i2c_unregister_device() is NULL safe Wolfram Sang
2019-09-03 17:52 ` Wolfram Sang
2019-09-04 8:26 ` Hans de Goede [this message]
2019-09-04 21:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e55f3cb-ba88-5404-3b38-585710976ed0@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox