From: Markus Elfring <Markus.Elfring@web.de>
To: Joe Perches <joe@perches.com>,
Dejin Zheng <zhengdejin5@gmail.com>,
linux-i2c@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Thor Thayer <thor.thayer@linux.intel.com>,
Tang Bin <tangbin@cmss.chinamobile.com>,
Stephen Boyd <swboyd@chromium.org>,
Patrick Williams <alpawi@amazon.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Adamski <krzysztof.adamski@nokia.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Barry Song <baohua@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
George Cherian <gcherian@marvell.com>,
Hans de Goede <hdegoede@redhat.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [v2] i2c: busses: remove duplicate dev_err()
Date: Thu, 16 Apr 2020 22:30:58 +0200 [thread overview]
Message-ID: <2e913d6d-fe20-1f0f-620c-ec37dc1a9195@web.de> (raw)
In-Reply-To: <7713a931e4475294de85b74aca298dde8be4242d.camel@perches.com>
>>> it will print an error message by itself when platform_get_irq()
>>> goes wrong. so don't need dev_err() in here again.
>>
>> I suggest to improve the commit message considerably.
>
> I suggest you ignore Markus' suggestion.
>
> The commit message is OK.
I would appreciate if such a view can be reconsidered.
I got used to looking at information which can be provided there.
Thus I occasionally notice further change possibilities
also at this place.
Examples:
* Should the first word in English sentences start with a capital letter?
* Which value do you give to an imperative wording in the change description?
* Will an other word order become helpful here?
* Can it be relevant to refer to questionable error messages
instead of the mentioned function name?
> The subject _could_ have included "platform_get_irq" something like
>
> Subject: [PATCH v2] i2c: busses: Remove platform_get_irq()'s duplicated dev_err()
I find such a suggestion for a patch subject also a bit nicer.
> but I believe it's not important enough to redo.
Will your idea be picked up for the final commit title?
Regards,
Markus
next prev parent reply other threads:[~2020-04-16 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 15:23 [PATCH v2] i2c: busses: remove duplicate dev_err() Dejin Zheng
2020-04-16 15:50 ` Andy Shevchenko
2020-04-16 18:22 ` Markus Elfring
2020-04-16 19:34 ` Joe Perches
2020-04-16 20:30 ` Markus Elfring [this message]
2020-04-16 21:29 ` Andy Shevchenko
2020-04-18 21:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e913d6d-fe20-1f0f-620c-ec37dc1a9195@web.de \
--to=markus.elfring@web.de \
--cc=aisheng.dong@nxp.com \
--cc=alpawi@amazon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=baohua@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=gcherian@marvell.com \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=narmstrong@baylibre.com \
--cc=swboyd@chromium.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=thor.thayer@linux.intel.com \
--cc=vigneshr@ti.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).