* [PATCH] i2c: i801: Hide Intel Birch Stream SoC TCO WDT
@ 2025-09-01 12:59 Chiasheng Lee
2025-09-01 13:35 ` Jarkko Nikula
2025-09-02 16:31 ` Andi Shyti
0 siblings, 2 replies; 3+ messages in thread
From: Chiasheng Lee @ 2025-09-01 12:59 UTC (permalink / raw)
To: Jarkko Nikula, Mika Westerberg, linux-i2c
Cc: Jean Delvare, Andi Shyti, Chiasheng Lee, stable
Hide the Intel Birch Stream SoC TCO WDT feature since it was removed.
On platforms with PCH TCO WDT, this redundant device might be rendering
errors like this:
[ 28.144542] sysfs: cannot create duplicate filename '/bus/platform/devices/iTCO_wdt'
Fixes: 8c56f9ef25a3 ("i2c: i801: Add support for Intel Birch Stream SoC")
Cc: <stable@vger.kernel.org>
Signed-off-by: Chiasheng Lee <chiasheng.lee@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=220320
---
drivers/i2c/busses/i2c-i801.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index a7f89946dad4..e94ac746a741 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1052,7 +1052,7 @@ static const struct pci_device_id i801_ids[] = {
{ PCI_DEVICE_DATA(INTEL, METEOR_LAKE_P_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
{ PCI_DEVICE_DATA(INTEL, METEOR_LAKE_SOC_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
{ PCI_DEVICE_DATA(INTEL, METEOR_LAKE_PCH_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
- { PCI_DEVICE_DATA(INTEL, BIRCH_STREAM_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
+ { PCI_DEVICE_DATA(INTEL, BIRCH_STREAM_SMBUS, FEATURES_ICH5) },
{ PCI_DEVICE_DATA(INTEL, ARROW_LAKE_H_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
{ PCI_DEVICE_DATA(INTEL, PANTHER_LAKE_H_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
{ PCI_DEVICE_DATA(INTEL, PANTHER_LAKE_P_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: i801: Hide Intel Birch Stream SoC TCO WDT
2025-09-01 12:59 [PATCH] i2c: i801: Hide Intel Birch Stream SoC TCO WDT Chiasheng Lee
@ 2025-09-01 13:35 ` Jarkko Nikula
2025-09-02 16:31 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Nikula @ 2025-09-01 13:35 UTC (permalink / raw)
To: Chiasheng Lee, Mika Westerberg, linux-i2c
Cc: Jean Delvare, Andi Shyti, stable
On 9/1/25 3:59 PM, Chiasheng Lee wrote:
> Hide the Intel Birch Stream SoC TCO WDT feature since it was removed.
>
> On platforms with PCH TCO WDT, this redundant device might be rendering
> errors like this:
>
> [ 28.144542] sysfs: cannot create duplicate filename '/bus/platform/devices/iTCO_wdt'
>
> Fixes: 8c56f9ef25a3 ("i2c: i801: Add support for Intel Birch Stream SoC")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Chiasheng Lee <chiasheng.lee@linux.intel.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=220320
> ---
> drivers/i2c/busses/i2c-i801.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index a7f89946dad4..e94ac746a741 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1052,7 +1052,7 @@ static const struct pci_device_id i801_ids[] = {
> { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_P_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
> { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_SOC_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
> { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_PCH_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
> - { PCI_DEVICE_DATA(INTEL, BIRCH_STREAM_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
> + { PCI_DEVICE_DATA(INTEL, BIRCH_STREAM_SMBUS, FEATURES_ICH5) },
> { PCI_DEVICE_DATA(INTEL, ARROW_LAKE_H_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
> { PCI_DEVICE_DATA(INTEL, PANTHER_LAKE_H_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
> { PCI_DEVICE_DATA(INTEL, PANTHER_LAKE_P_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) },
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: i801: Hide Intel Birch Stream SoC TCO WDT
2025-09-01 12:59 [PATCH] i2c: i801: Hide Intel Birch Stream SoC TCO WDT Chiasheng Lee
2025-09-01 13:35 ` Jarkko Nikula
@ 2025-09-02 16:31 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2025-09-02 16:31 UTC (permalink / raw)
To: Chiasheng Lee
Cc: Jarkko Nikula, Mika Westerberg, linux-i2c, Jean Delvare, stable
Hi Chiasheng,
On Mon, Sep 01, 2025 at 08:59:43PM +0800, Chiasheng Lee wrote:
> Hide the Intel Birch Stream SoC TCO WDT feature since it was removed.
>
> On platforms with PCH TCO WDT, this redundant device might be rendering
> errors like this:
>
> [ 28.144542] sysfs: cannot create duplicate filename '/bus/platform/devices/iTCO_wdt'
>
> Fixes: 8c56f9ef25a3 ("i2c: i801: Add support for Intel Birch Stream SoC")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Chiasheng Lee <chiasheng.lee@linux.intel.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=220320
merged to i2c/i2c-host-fixes.
Thanks,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-02 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 12:59 [PATCH] i2c: i801: Hide Intel Birch Stream SoC TCO WDT Chiasheng Lee
2025-09-01 13:35 ` Jarkko Nikula
2025-09-02 16:31 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).