From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: Andi Shyti <andi.shyti@kernel.org>,
Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-i2c@vger.kernel.org, syniurge@gmail.com,
Raju.Rangoju@amd.com, basavaraj.natikar@amd.com, wsa@kernel.org
Subject: Re: [PATCH -next] i2c: amd-mp2: drop free_irq() of devm_request_irq() allocated irq
Date: Thu, 20 Mar 2025 17:12:34 +0530 [thread overview]
Message-ID: <301f186b-a558-4242-b2f6-164b56fef56c@amd.com> (raw)
In-Reply-To: <2mlgmmld4kih7fvt3bv2fzy2mgkbierbmtmzfbdy2cqweu7txh@tosw5go7mksd>
On 3/20/2025 16:46, Andi Shyti wrote:
> Hi Yang,
>
> On Thu, Nov 03, 2022 at 08:11:46PM +0800, Yang Yingliang wrote:
>> irq allocated with devm_request_irq() will be freed in devm_irq_release(),
>> using free_irq() in ->remove() will causes a dangling pointer, and a
>> subsequent double free. So remove the free_irq() in the error path and
>> remove path.
>>
>> Fixes: 969864efae78 ("i2c: amd-mp2: use msix/msi if the hardware supports")
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> No ack from Ellie and Shyam have come for this patch in almost
> two years. It still applies and it still looks correct to me.
>
> I'm merging it into i2c/i2c-host-fixes in order to have it in
> time for the tests before the pull requests. If Ellie and/or
> Shyam will have concerns, we are still in time to take it off.
>
Sorry, I missed this.
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Thanks,
Shyam
next prev parent reply other threads:[~2025-03-20 11:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 12:11 [PATCH -next] i2c: amd-mp2: drop free_irq() of devm_request_irq() allocated irq Yang Yingliang
2023-06-08 20:36 ` Wolfram Sang
2024-03-05 21:49 ` Andi Shyti
2025-03-20 11:16 ` Andi Shyti
2025-03-20 11:42 ` Shyam Sundar S K [this message]
2025-03-20 13:39 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=301f186b-a558-4242-b2f6-164b56fef56c@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=Raju.Rangoju@amd.com \
--cc=andi.shyti@kernel.org \
--cc=basavaraj.natikar@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=syniurge@gmail.com \
--cc=wsa@kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox