From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Wolfram Sang <wsa@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/9] i2c: qcom-cci: fixes and updates
Date: Thu, 17 Feb 2022 23:47:03 +0200 [thread overview]
Message-ID: <303a2bfd-b3d2-97a8-2438-fefe13a49962@linaro.org> (raw)
In-Reply-To: <Yg6oxrlQZIsJCkUY@kunai>
Hi Wolfram,
On 2/17/22 9:57 PM, Wolfram Sang wrote:
>
>> Vladimir Zapolskiy (9):
>> dt-bindings: i2c: qcom-cci: add QCOM SM8450 compatible
>> dt-bindings: i2c: qcom-cci: add description of a vbus-supply property
>> i2c: qcom-cci: don't delete an unregistered adapter
>> i2c: qcom-cci: don't put a device tree node before i2c_add_adapter()
>> i2c: qcom-cci: initialize CCI controller after registration of adapters
>> i2c: qcom-cci: simplify probe by removing one loop over busses
>> i2c: qcom-cci: simplify access to bus data structure
>> i2c: qcom-cci: add support of optional vbus-supply regulators
>> i2c: qcom-cci: add sm8450 compatible
>
> Patches 3+4 are already upstream. I wonder if patches 1+9 could be
> applied to for-next also? Or is the vbus-supply a hard dependency here?
> Patches 6+7 could probably also be resent individually after some
> rebasing.
>
thank you for applying the fixes, 1/9 and 9/9 are also good to be applied
for-next, there is no dependency on vbus-supply, so I would appreciate, if
you take two more changes.
As you suggested I'd start working on a generic support of such an optional
bus supplier property, I believe at the moment everything is quite clear,
I'll start from testing the previous solution, however my preference is
to connect regulator on/off to master controller pm ops rather than slave
pm ops. Additionally I am not quite satisfied with 'vbus-supply' name,
some name without a confusing starting 'v' should be preferred IMO, like
'i2c-bus-supply' or 'sda-scl-supply', name suggestions are welcome.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2022-02-17 21:47 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 16:46 [PATCH 0/9] i2c: qcom-cci: fixes and updates Vladimir Zapolskiy
2022-02-03 16:46 ` [PATCH 1/9] dt-bindings: i2c: qcom-cci: add QCOM SM8450 compatible Vladimir Zapolskiy
2022-02-04 11:04 ` Robert Foss
2022-02-11 14:12 ` Rob Herring
2022-02-18 9:02 ` Wolfram Sang
2022-02-03 16:46 ` [PATCH 2/9] dt-bindings: i2c: qcom-cci: add description of a vbus-supply property Vladimir Zapolskiy
2022-02-04 11:06 ` Robert Foss
2022-02-04 18:05 ` Bjorn Andersson
2022-02-04 18:42 ` Mark Brown
2022-02-04 19:02 ` Bjorn Andersson
2022-02-04 19:32 ` Mark Brown
2022-02-07 14:08 ` Vladimir Zapolskiy
2022-02-07 14:39 ` Mark Brown
2022-02-07 18:31 ` Vladimir Zapolskiy
2022-02-08 12:55 ` Mark Brown
2022-02-10 15:33 ` Dmitry Baryshkov
2022-02-10 15:44 ` Mark Brown
2022-02-10 17:32 ` Dmitry Baryshkov
2022-02-10 17:36 ` Mark Brown
2022-02-10 18:21 ` Dmitry Baryshkov
2022-02-10 18:26 ` Mark Brown
2022-02-10 19:02 ` Dmitry Baryshkov
2022-02-03 16:47 ` [PATCH 3/9] i2c: qcom-cci: don't delete an unregistered adapter Vladimir Zapolskiy
2022-02-04 10:05 ` Robert Foss
2022-02-04 18:08 ` Bjorn Andersson
2022-02-11 17:45 ` Wolfram Sang
2022-02-11 17:43 ` Wolfram Sang
2022-02-03 16:47 ` [PATCH 4/9] i2c: qcom-cci: don't put a device tree node before i2c_add_adapter() Vladimir Zapolskiy
2022-02-04 10:17 ` Robert Foss
2022-02-04 18:11 ` Bjorn Andersson
2022-02-11 17:44 ` Wolfram Sang
2022-02-03 16:47 ` [PATCH 5/9] i2c: qcom-cci: initialize CCI controller after registration of adapters Vladimir Zapolskiy
2022-02-03 17:29 ` Loic Poulain
2022-02-03 18:45 ` Vladimir Zapolskiy
2022-02-04 11:18 ` Loic Poulain
2022-02-04 18:31 ` Bjorn Andersson
2022-02-03 16:47 ` [PATCH 6/9] i2c: qcom-cci: simplify probe by removing one loop over busses Vladimir Zapolskiy
2022-02-04 10:20 ` Robert Foss
2022-02-03 16:47 ` [PATCH 7/9] i2c: qcom-cci: simplify access to bus data structure Vladimir Zapolskiy
2022-02-04 10:21 ` Robert Foss
2022-02-03 16:47 ` [PATCH 8/9] i2c: qcom-cci: add support of optional vbus-supply regulators Vladimir Zapolskiy
2022-02-04 11:03 ` Robert Foss
2022-02-04 11:41 ` Loic Poulain
2022-02-04 18:28 ` Bjorn Andersson
2022-02-10 15:37 ` Dmitry Baryshkov
2022-02-04 18:21 ` Bjorn Andersson
2022-02-03 16:47 ` [PATCH 9/9] i2c: qcom-cci: add sm8450 compatible Vladimir Zapolskiy
2022-02-04 11:03 ` Robert Foss
2022-02-18 9:02 ` Wolfram Sang
2022-02-11 17:49 ` [PATCH 0/9] i2c: qcom-cci: fixes and updates Wolfram Sang
2022-02-11 19:46 ` Vladimir Zapolskiy
2022-02-11 20:43 ` Wolfram Sang
2022-02-17 19:57 ` Wolfram Sang
2022-02-17 21:47 ` Vladimir Zapolskiy [this message]
2022-02-18 9:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=303a2bfd-b3d2-97a8-2438-fefe13a49962@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).