From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Richard Acayan <mailingradian@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-media@vger.kernel.org,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH v5 4/7] dt-bindings: media: camss: Add qcom,sdm670-camss
Date: Tue, 1 Oct 2024 10:09:09 +0100 [thread overview]
Message-ID: <306b0806-70c5-4dfb-b7e3-5614a20699d2@linaro.org> (raw)
In-Reply-To: <aleot5kegf5xvlvzmws6tmxcqxw3gnmxndclkb7rdzcxnmehel@varsfzbmiszm>
On 01/10/2024 07:53, Krzysztof Kozlowski wrote:
>> + reg-names:
>> + items:
>> + - const: csiphy0
>> + - const: csiphy1
>> + - const: csiphy2
>> + - const: vfe0
>> + - const: csid0
>> + - const: vfe1
>> + - const: csid1
>> + - const: vfe_lite
>> + - const: csid2
> Why this order is so different than all others? This is supposed to
> match other devices. Look at sdm845 for example.
These are appearing in address order, which is preferred over reg-name
ordering AFAIU.
+ reg = <0 0x0ac65000 0 0x1000>,
+ <0 0x0ac66000 0 0x1000>,
+ <0 0x0ac67000 0 0x1000>,
+ <0 0x0acaf000 0 0x4000>,
+ <0 0x0acb3000 0 0x1000>,
+ <0 0x0acb6000 0 0x4000>,
+ <0 0x0acba000 0 0x1000>,
+ <0 0x0acc4000 0 0x4000>,
+ <0 0x0acc8000 0 0x1000>;
+ reg-names = "csiphy0",
+ "csiphy1",
+ "csiphy2",
+ "vfe0",
+ "csid0",
+ "vfe1",
+ "csid1",
+ "vfe_lite",
+ "csid2";
---
bod
next prev parent reply other threads:[~2024-10-01 9:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 2:35 [PATCH v5 0/7] Add SDM670 camera subsystem Richard Acayan
2024-10-01 2:35 ` [PATCH v5 1/7] dt-bindings: clock: qcom,sdm845-camcc: add sdm670 compatible Richard Acayan
2024-10-01 2:35 ` [PATCH v5 2/7] dt-bindings: i2c: qcom-cci: Document SDM670 compatible Richard Acayan
2024-10-01 6:49 ` Krzysztof Kozlowski
2024-10-01 2:35 ` [PATCH v5 3/7] i2c: qcom-cci: Stop complaining about DT set clock rate Richard Acayan
2024-10-01 2:35 ` [PATCH v5 4/7] dt-bindings: media: camss: Add qcom,sdm670-camss Richard Acayan
2024-10-01 6:53 ` Krzysztof Kozlowski
2024-10-01 9:09 ` Bryan O'Donoghue [this message]
2024-10-01 9:47 ` Krzysztof Kozlowski
2024-10-01 9:54 ` Bryan O'Donoghue
2024-10-01 10:03 ` Krzysztof Kozlowski
2024-10-01 2:35 ` [PATCH v5 5/7] media: qcom: camss: add support for SDM670 camss Richard Acayan
2024-10-01 2:35 ` [PATCH v5 6/7] arm64: dts: qcom: sdm670: add camcc Richard Acayan
2024-10-01 2:35 ` [PATCH v5 7/7] arm64: dts: qcom: sdm670: add camss and cci Richard Acayan
2024-10-02 8:53 ` [PATCH v5 0/7] Add SDM670 camera subsystem Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=306b0806-70c5-4dfb-b7e3-5614a20699d2@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mailingradian@gmail.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).