From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>, jsd@semihalf.com
Cc: andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next v2 RESEND] i2c: designware: remove unneeded semicolon
Date: Mon, 14 Feb 2022 15:03:33 +0200 [thread overview]
Message-ID: <307ca790-e9ca-c8f3-e0f7-28ad594db2aa@linux.intel.com> (raw)
In-Reply-To: <20220214124701.105814-1-yang.lee@linux.alibaba.com>
Hi
On 2/14/22 14:47, Yang Li wrote:
> Eliminate the following coccicheck warnings:
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>
> --Changes in v2:
> According to Jan's suggestion
> Fix the same problem in check_i2c_req_sts() function.
>
> drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
For future contributions: Technically this would be v3 rather than v2
RESEND since you fixed the typo in commit log noted by Jan for v2.
Please use RESEND only if you'll send exactly the same version for
instance if you didn't receive any comments for several weeks or some
recipient was missing from Cc field.
I believe Jan will give Reviewed-by tag to this version too.
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-02-14 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 12:47 [PATCH -next v2 RESEND] i2c: designware: remove unneeded semicolon Yang Li
2022-02-14 13:03 ` Jarkko Nikula [this message]
2022-02-14 14:01 ` Jan Dąbroś
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307ca790-e9ca-c8f3-e0f7-28ad594db2aa@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=abaci@linux.alibaba.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox