From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Farouk Bouabid <farouk.bouabid@cherry.de>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Quentin Schulz <quentin.schulz@cherry.de>,
Peter Rosin <peda@axentia.se>, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v8 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer
Date: Sat, 28 Sep 2024 18:56:40 +0200 [thread overview]
Message-ID: <316e200d-74b6-4d03-952e-e8612276f0e8@wanadoo.fr> (raw)
In-Reply-To: <20240906-dev-mule-i2c-mux-v8-2-dbd28a150e41@cherry.de>
Le 06/09/2024 à 17:54, Farouk Bouabid a écrit :
> Theobroma Systems Mule is an MCU that emulates a set of I2C devices,
> among which an amc6821 and devices that are reachable through an I2C-mux.
> The devices on the mux can be selected by writing the appropriate device
> number to an I2C config register (amc6821 reg 0xff).
>
> This driver is expected to be probed as a platform device with amc6821
> as its parent i2c device.
>
> Add support for the mule-i2c-mux platform driver. The amc6821 driver
> support for the mux will be added in a later commit.
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Farouk Bouabid <farouk.bouabid@cherry.de>
> ---
Hi,
> +static const struct of_device_id mule_i2c_mux_of_match[] = {
> + { .compatible = "tsd,mule-i2c-mux", },
> + {},
Nitpick (in case of v9): usually, a comma is not added after a terminator.
> +};
...
next prev parent reply other threads:[~2024-09-28 16:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 15:54 [PATCH v8 0/8] Add tsd,mule-i2c-mux support Farouk Bouabid
2024-09-06 15:54 ` [PATCH v8 1/8] dt-bindings: i2c: add support for tsd,mule-i2c-mux Farouk Bouabid
2024-09-06 15:54 ` [PATCH v8 2/8] i2c: muxes: add support for tsd,mule-i2c multiplexer Farouk Bouabid
2024-09-28 16:56 ` Christophe JAILLET [this message]
2024-09-28 17:00 ` Guenter Roeck
2024-09-06 15:54 ` [PATCH v8 3/8] dt-bindings: hwmon: add support for ti,amc6821 Farouk Bouabid
2024-09-27 14:58 ` Farouk Bouabid
2024-09-28 16:39 ` Guenter Roeck
2024-09-29 23:52 ` Guenter Roeck
2024-09-06 15:54 ` [PATCH v8 4/8] hwmon: (amc6821) add support for tsd,mule Farouk Bouabid
2024-09-29 23:53 ` Guenter Roeck
2024-09-06 15:54 ` [PATCH v8 5/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on rk3588-jaguar Farouk Bouabid
2024-09-06 15:54 ` [PATCH v8 6/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on rk3399-puma Farouk Bouabid
2024-09-06 15:54 ` [PATCH v8 7/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on rk3588-tiger Farouk Bouabid
2024-09-06 15:54 ` [PATCH v8 8/8] arm64: dts: rockchip: add tsd,mule-i2c-mux on px30-ringneck Farouk Bouabid
2024-09-07 8:34 ` [PATCH v8 0/8] Add tsd,mule-i2c-mux support Andi Shyti
2024-09-30 10:55 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=316e200d-74b6-4d03-952e-e8612276f0e8@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farouk.bouabid@cherry.de \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=peda@axentia.se \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).