[PATCH] Fix Kconfig for I2C-Algos

[PATCH] Fix Kconfig for I2C-Algos

[Christian Gmeiner]

[-- Attachment #1: Type: text/plain, Size: 127 bytes --]

HI,

this patch fixes wrong kconf file so that it will be possible to
select wanted i2c algorithms.

greets,
Christian Gmeiner

[-- Attachment #2: i2c_kconfig.patch --]
[-- Type: application/octet-stream, Size: 584 bytes --]

diff --git a/drivers/i2c/algos/Kconfig b/drivers/i2c/algos/Kconfig
index 7137a17..91d7fff 100644
--- a/drivers/i2c/algos/Kconfig
+++ b/drivers/i2c/algos/Kconfig
@@ -1,16 +1,19 @@
 #
 # I2C algorithm drivers configuration
 #
+menu "I2C Algorithms"
 
 config I2C_ALGOBIT
-	tristate
+	tristate "I2C bit-banging interfaces"
 
 config I2C_ALGOPCF
-	tristate
+	tristate "I2C PCF 8584 interfaces"
 
 config I2C_ALGOPCA
-	tristate
+	tristate "I2C PCA 9564 interfaces"
 
 config I2C_ALGO_SGI
-	tristate
+	tristate "I2C SGI interfaces"
 	depends on SGI_IP22 || SGI_IP32 || X86_VISWS
+
+endmenu

[-- Attachment #3: Type: text/plain, Size: 157 bytes --]

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] Fix Kconfig for I2C-Algos

[Jean Delvare]

Hi Christian,

On Mon, 16 Jun 2008 17:24:59 +0000, Christian Gmeiner wrote:
> this patch fixes wrong kconf file so that it will be possible to
> select wanted i2c algorithms.

We moved in the exact opposite direction two months ago, on the basis
that i2c bus drivers select the algorithm driver they need
automatically so the user shouldn't have to care:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3845de25c5f83cd52729570f7b501679d37ca8de

So, it's not a bug, it's a feature. If you have some i2c bus driver
which needs an i2c algorithm driver and doesn't select it, fix that
driver.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] Fix Kconfig for I2C-Algos

[Christian Gmeiner]

Hi Jean,

>
> So, it's not a bug, it's a feature. If you have some i2c bus driver
> which needs an i2c algorithm driver and doesn't select it, fix that
> driver.

I see, but whats the plan with external drivers, like
http://dxr3.sourceforge.net/ ?
Without the manual selection it is not possible to get it working.

Christian

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: [PATCH] Fix Kconfig for I2C-Algos

[Jean Delvare]

On Tue, 17 Jun 2008 06:01:52 +0000, Christian Gmeiner wrote:
> > So, it's not a bug, it's a feature. If you have some i2c bus driver
> > which needs an i2c algorithm driver and doesn't select it, fix that
> > driver.
> 
> I see, but whats the plan with external drivers, like
> http://dxr3.sourceforge.net/ ?

First of all: drivers living outside of the kernel tree, get the pain
the deserve. Their authors should really merge their work in the kernel
tree, to avoid this kind of problem and many others.

> Without the manual selection it is not possible to get it working.

Simply select any driver which needs i2c-algo-bit in the kernel tree.
For example "I2C Hardware Bus support > Parallel port adapter (light)".
This will select i2c-algo-bit for you.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c