From: Peter Rosin <peda@axentia.se>
To: Mawanda Henry <mawandahenrynaco@gmail.com>, mawanda111@gmail.com
Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/i2c: Include SPDX-license-identifier
Date: Thu, 21 Jun 2018 11:45:54 +0200 [thread overview]
Message-ID: <331d6408-e61f-6227-da44-0aa26078da0c@axentia.se> (raw)
In-Reply-To: <20180621094019.GA5348@sesnaco>
On 2018-06-21 11:40, Mawanda Henry wrote:
> including the SPDX license identifier header makes it easy for
> developers and machines to know the lecense that is governing the file
If you do changes like this, you should also remove the actual
license text (it follows later in the comment in this case). And
more importantly, you should make *sure* that you use the correct
SPDX tag, which you don't in this case.
So, you need to fix those issues.
Cheers,
Peter
> Signed-off-by: Mawanda Henry <mawandahenrynaco@gmail.com>
> ---
> drivers/i2c/i2c-core-slave.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/i2c-core-slave.c b/drivers/i2c/i2c-core-slave.c
> index 4a78c65..883ca836 100644
> --- a/drivers/i2c/i2c-core-slave.c
> +++ b/drivers/i2c/i2c-core-slave.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Linux I2C core slave support code
> *
>
prev parent reply other threads:[~2018-06-21 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 9:40 [PATCH] drivers/i2c: Include SPDX-license-identifier Mawanda Henry
2018-06-21 9:45 ` Peter Rosin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331d6408-e61f-6227-da44-0aa26078da0c@axentia.se \
--to=peda@axentia.se \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mawanda111@gmail.com \
--cc=mawandahenrynaco@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox