From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v4 2/2] eeprom: at24: Add support for address-width property Date: Fri, 29 Jun 2018 19:14:57 +0300 Message-ID: <33642a4af01344cda16fd09c58d79ceee0b81f25.camel@linux.intel.com> References: <1530256915-25034-1-git-send-email-alanx.chiang@intel.com> <1530256915-25034-3-git-send-email-alanx.chiang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1530256915-25034-3-git-send-email-alanx.chiang@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: alanx.chiang@intel.com, linux-i2c@vger.kernel.org Cc: andy.yeh@intel.com, sakari.ailus@linux.intel.com, rajmohan.mani@intel.com, andy.shevchenko@gmail.com, tfiga@chromium.org, jcliang@chromium.org, brgl@bgdev.pl, robh+dt@kernel.org, mark.rutland@arm.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On Fri, 2018-06-29 at 15:21 +0800, alanx.chiang@intel.com wrote: > From: Alan Chiang > > Provide a flexible way to determine the addressing bits of eeprom. > Pass the addressing bits to driver through address-width property. > Reviewed-by: Andy Shevchenko > Signed-off-by: Alan Chiang > Signed-off-by: Andy Yeh > > --- > since v1 > -- Add a warn message for 8-bit addressing. > since v2 > -- Modify the warning message for clear. > -- Move the clearing bit operation outside of a statement. > since v3 > -- Merge the warning message into one line. > > --- > drivers/misc/eeprom/at24.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > index 0c125f2..7ea640b 100644 > --- a/drivers/misc/eeprom/at24.c > +++ b/drivers/misc/eeprom/at24.c > @@ -478,6 +478,23 @@ static void at24_properties_to_pdata(struct > device *dev, > if (device_property_present(dev, "no-read-rollover")) > chip->flags |= AT24_FLAG_NO_RDROL; > > + err = device_property_read_u32(dev, "address-width", &val); > + if (!err) { > + switch (val) { > + case 8: > + if (chip->flags & AT24_FLAG_ADDR16) > + dev_warn(dev, "Override address width > to be 8, while default is 16\n"); > + chip->flags &= ~AT24_FLAG_ADDR16; > + break; > + case 16: > + chip->flags |= AT24_FLAG_ADDR16; > + break; > + default: > + dev_warn(dev, "Bad \"address-width\" > property: %u\n", > + val); > + } > + } > + > err = device_property_read_u32(dev, "size", &val); > if (!err) > chip->byte_len = val; -- Andy Shevchenko Intel Finland Oy