From: Heiko Stuebner <heiko@sntech.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] i2c: rk3x: add proper kerneldoc header
Date: Thu, 18 Jan 2018 00:19:52 +0100 [thread overview]
Message-ID: <3433285.yBKRl3OqfX@phil> (raw)
In-Reply-To: <20180117231817.26955-1-wsa@the-dreams.de>
Am Donnerstag, 18. Januar 2018, 00:18:17 CET schrieb Wolfram Sang:
> gcc noticed the kerneldoc was wrongly formatted. Fix it!
>
> drivers/i2c/busses/i2c-rk3x.c:164: warning:
> Cannot understand * @grf_offset: ...
> on line 164 - I thought it was a doc line
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
If you need it,
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
>
> It also found this, but I leave this for now. Maybe someone else is interested:
>
> drivers/i2c/busses/i2c-rk3x.c:247: warning: No description found for parameter 'i2c'
> drivers/i2c/busses/i2c-rk3x.c:268: warning: No description found for parameter 'i2c'
> drivers/i2c/busses/i2c-rk3x.c:306: warning: No description found for parameter 'i2c'
> drivers/i2c/busses/i2c-rk3x.c:337: warning: No description found for parameter 'i2c'
> drivers/i2c/busses/i2c-rk3x.c:975: warning: No description found for parameter 'i2c'
>
> drivers/i2c/busses/i2c-rk3x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 1f80960c5ae1c8..e1a18d989f8307 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -161,6 +161,7 @@ enum rk3x_i2c_state {
> };
>
> /**
> + * struct rk3x_i2c_soc_data:
> * @grf_offset: offset inside the grf regmap for setting the i2c type
> * @calc_timings: Callback function for i2c timing information calculated
> */
>
next prev parent reply other threads:[~2018-01-17 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 23:18 [PATCH] i2c: rk3x: add proper kerneldoc header Wolfram Sang
2018-01-17 23:19 ` Heiko Stuebner [this message]
2018-01-17 23:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3433285.yBKRl3OqfX@phil \
--to=heiko@sntech.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox