From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m32104.qiye.163.com (mail-m32104.qiye.163.com [220.197.32.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4338B2066F4; Fri, 10 Jan 2025 08:34:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.104 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736498072; cv=none; b=PZzb2QaGmoE4qa2SiqDbxSwezRAtc+QbHe0Wl9BmgTwXwa2jQhkC6cR4pUMT3G5+G/dv36JxWFAQPWcFrDBK1AB+K4mafnvgBwDQ07tCvaC9CPshJGNCSi65IG6/Q4XJbweaqi7PphCUpN3iDw2gPUoSI3KKfXjggAW/9Uiim8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736498072; c=relaxed/simple; bh=qEqPTF4nULWoVTAeKGSvjXgapT7N5A2egnTUmjMD040=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KbV3dSDwk50QJXJWxszOm1L54bz24j7cZYXBGsQ+DGIK/WptC0bG5PeDQpSYJWksvwouiTdDb+W2iwK7/eMMbhuLCGimJ0VHcJ5lh/xMbpX4rMq4X6qotJrhpabLUwMTmxSHdewJcsGCOa637k/8hH2krkcySWr0FJMmBke9kPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=VWXK7s8d; arc=none smtp.client-ip=220.197.32.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="VWXK7s8d" Received: from [172.16.12.67] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 851e8425; Fri, 10 Jan 2025 15:58:45 +0800 (GMT+08:00) Message-ID: <3460b2a3-9579-4a12-9eff-6e2f1a1cc91c@rock-chips.com> Date: Fri, 10 Jan 2025 15:58:44 +0800 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/17] rockchip: Add rk3562 support To: Krzysztof Kozlowski Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, Simon Xue , Guenter Roeck , Mark Brown , Chris Morgan , Frank Wang , Jamie Iles , Bjorn Helgaas , linux-pci@vger.kernel.org, Jonas Karlman , Johan Jonker , David Airlie , dri-devel@lists.freedesktop.org, Sebastian Reichel , linux-i2c@vger.kernel.org, Shawn Lin , Simona Vetter , Elaine Zhang , Conor Dooley , Finley Xiao , Maxime Ripard , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , FUKAUMI Naoki , linux-pwm@vger.kernel.org, Krzysztof Kozlowski , Andy Yan , linux-serial@vger.kernel.org, Michael Riesch , Greg Kroah-Hartman , Jiri Slaby , Andi Shyti , devicetree@vger.kernel.org, Diederik de Haas , linux-watchdog@vger.kernel.org, Rob Herring , Lee Jones , Cristian Ciocaltea , Wim Van Sebroeck , Shresth Prasad , Tim Lunn , Lorenzo Pieralisi , Maarten Lankhorst , linux-arm-kernel@lists.infradead.org, Ulf Hansson , Jisheng Zhang , Dragan Simic , Detlev Casanova , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org, Manivannan Sadhasivam , Thomas Zimmermann , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= References: <20241224094920.3821861-1-kever.yang@rock-chips.com> Content-Language: en-US From: Kever Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGh4dTlYZGR1MSR1MTk5JGkJWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhCS0 NVSktLVUpCWQY+ X-HM-Tid: 0a944f3909e403afkunm851e8425 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OTY6FBw4LDIQPQ8VMiJKC0lO K0kaCUlVSlVKTEhNT0JOQklCSkNLVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJQktCNwY+ DKIM-Signature:a=rsa-sha256; b=VWXK7s8da0RDYOHxSWhWmVquzr9JT8B4nkrF/smFefecdntF1wQ00XwWP/W6zJg+9nzjib8DolV9vW+B7e4x9e94nqGrRa3NUYOfsb8LiB93JM1o4goCzIFl5gMoV51sQZuv+O5c3/QadXRtYtLINbjhyZzW/2jq4/AD/N9qfGU=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=jhJHF5kfM0cVe+RkIB8dEyszOtU3eaBDxOU11VNcLG4=; h=date:mime-version:subject:message-id:from; Hi Krzysztof,     Thanks very much for your review. On 2024/12/27 15:38, Krzysztof Kozlowski wrote: > On Tue, Dec 24, 2024 at 05:49:03PM +0800, Kever Yang wrote: >> This patch set adds rk3562 SoC and its evb support. >> >> Split out patches belong to different subsystem. >> >> Test with GMAC, USB, PCIe, EMMC, SD Card. >> >> This patch set is base on the patche set for rk3576 evb1 support. >> >> Changes in v2: >> - Update in sort order >> - remove grf in cru >> - Update some properties order >> >> Finley Xiao (2): >> arm64: dts: rockchip: add core dtsi for RK3562 Soc >> arm64: dts: rockchip: Add RK3562 evb2 devicetree >> >> Kever Yang (15): >> dt-bindings: PCI: dwc: rockchip: Add rk3562 support >> dt-bindings: mmc: Add support for rk3562 eMMC >> dt-bindings: mmc: rockchip-dw-mshc: Add rk3562 compatible string >> dt-bindings: power: rockchip: Add bindings for rk3562 >> dt-bindings: i2c: i2c-rk3x: Add rk3562 compatible >> dt-bindings: gpu: Add rockchip,rk3562-mali compatible >> dt-bindings: watchdog: Add rk3562 compatible >> dt-bindings: spi: Add rockchip,rk3562-spi compatible >> dt-bindings: serial: snps-dw-apb-uart: Add support for rk3562 >> dt-bindings: usb: dwc3: add compatible for rk3562 >> dt-bindings: pwm: rockchip: Add rockchip,rk3562-pwm >> dt-bindings: rockchip: pmu: Add rk3562 compatible >> dt-bindings: soc: rockchip: Add rk3562 syscon compatibles >> dt-bindings: arm: rockchip: Add rk3562 evb2 board >> dt-bindings: mfd: syscon: Add rk3562 QoS register compatible > You squezzed here like 12 different subsystems. Some of these changes > suggest missing drivers. I have split out all the patches with driver change as separate patch set. All the other dt-binding patches in this patchset is re-use the driver without any change, but only add a new "rockchip, rk3562-" based compatible entry, and also no more info need to explain in the commit message which I usually copy from commit msg already in tree and change the soc to rk3562. I think this patch set will be clear enough for the new soc/board support. So do you mean I have to send the 1st~15th of this patchset one by one separately so that they can reach to different subsystems? I believe there is no much useful change for the cc list is provide by the tool automatically and the commit msg can update as Uwe's suggestion: The PWM core on Rockchip's RK3562 is the same as the one already included in RK3328. Extend the binding accordingly to allow compatible = "rockchip,rk3562-pwm", "rockchip,rk3328-pwm"; Thanks, - Kever > > Please read basic upstreaming guide, some previous discussions and get > internal rock-chips help so we want repeat basics over and over. > > Bindings are with drivers. Send them to respective subsystems. > > Best regards, > Krzysztof > >