From: David Lechner <david@lechnology.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] LEGO MINDSTORMS I2C support
Date: Fri, 16 Sep 2016 15:05:45 -0500 [thread overview]
Message-ID: <35c2d50b-4d1e-deb4-9b9e-a9f8b33a7f36@lechnology.com> (raw)
In-Reply-To: <20160915200045.GE7863@katana>
On 09/15/2016 03:00 PM, Wolfram Sang wrote:
> On Mon, Sep 05, 2016 at 03:40:11PM -0500, David Lechner wrote:
>> I'm working on getting LEGO MINDSTORMS[1] support in the Linux kernel.
>>
>> They have a system of modular sensors that are hot-plugable, some of which use
>> I2C communications. Unfortunately, these don't necessary follow standard I2C
>> conventions, but they do have a well-defined register layout, so they are
>> easy to detect.
>>
>> This set of patches addresses the hot-plugability of the sensors.
>>
>> [1]: http://mindstorms.lego.com
>
> Thanks!
>
> For a review, I'd need users of this functionality. In this case, a
> master driver and probably a sensor driver.
Work in progress drivers:
master:
https://github.com/ev3dev/lego-linux-drivers/blob/master/ev3/legoev3_i2c.c
master:
https://github.com/ev3dev/lego-linux-drivers/blob/master/evb/evb_pru_i2c.c
sensor:
https://github.com/ev3dev/lego-linux-drivers/blob/master/sensors/nxt_i2c_sensor_core.c
> Can any regular I2C master
> talk to these devices if they support talking to addresses 0x00-0x7f?
Yes. I've tested this with the SoC I2C on Raspberry Pi. There are
several 3rd party LEGO MINDSTORMS compatible addon boards for RPi that
use the SoC I2C with LEGO sensors, which is part of my motivation for
this patchset.
> My first impression is that using a class is not the proper approach
> because classes were used to limit access to devices, not to extend.
> However, I'd need to see more code to check if that holds true.
>
I'm certainly open to other suggestions. This just seemed like the
obvious way to me.
prev parent reply other threads:[~2016-09-16 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 20:40 [PATCH 0/3] LEGO MINDSTORMS I2C support David Lechner
2016-09-05 20:40 ` [PATCH 1/3] i2c: Add class for LEGO MINDSTORMS sensors David Lechner
2016-09-06 19:01 ` Uwe Kleine-König
2016-09-05 20:40 ` [PATCH 2/3] i2c: Add special case for detecting LEGO devices David Lechner
2016-09-05 20:40 ` [PATCH 3/3] i2c: expose adapter probe and remove probed functions David Lechner
2016-09-16 21:03 ` Wolfram Sang
2016-09-16 21:09 ` David Lechner
2016-09-15 20:00 ` [PATCH 0/3] LEGO MINDSTORMS I2C support Wolfram Sang
2016-09-16 20:05 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c2d50b-4d1e-deb4-9b9e-a9f8b33a7f36@lechnology.com \
--to=david@lechnology.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).