From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PULL REQUEST] i2c for 3.13 Date: Tue, 19 Nov 2013 01:11:25 +0100 Message-ID: <3690707.5664qBQcL8@vostro.rjw.lan> References: <20131118193802.GA14925@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Torvalds Cc: Wolfram Sang , "Rafael J. Wysocki" , Jean Delvare , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List , Mika Westerberg List-Id: linux-i2c@vger.kernel.org On Monday, November 18, 2013 03:46:34 PM Linus Torvalds wrote: > On Mon, Nov 18, 2013 at 11:38 AM, Wolfram Sang wrote: > > > > here is the pull request from the i2c subsystem for 3.13: > > So while resolving some fairly trivial conflicts here, I noticed that > commit a76e9bd89ae7 ("i2c: attach/detach I2C client device to the ACPI > power domain") that I got earlier through the ACPI/PM tree calls > acpi_dev_pm_detach() even when the device "->remove()" function fails. > But it only sets clientdata to NULL if it succeeds. > > That looks a bit odd. > > I didn't try to fix it, though. I just thought I'd point out the oddity. Well, given that the driver core doesn't even check the return value of dev->bus->remove(dev), I think doing the unconditional acpi_dev_pm_detach() is actually correct and clientdata should be cleared unconditionally too. Rafael