From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Phil Reid <preid@electromag.com.au>,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, wsa@the-dreams.de,
linux-i2c@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: [PATCH 1/2] i2c: core: fix compile issue related to incorrect gpio header
Date: Tue, 28 Nov 2017 11:04:41 +0200 [thread overview]
Message-ID: <380c34f9-6501-a11c-b077-670d4a1346aa@linux.intel.com> (raw)
In-Reply-To: <1511838551-4035-2-git-send-email-preid@electromag.com.au>
On 11/28/2017 05:09 AM, Phil Reid wrote:
> The correct header to include for the gpiod interface is
> <linux/gpio/consumer.h>.
>
> fixes commit 3991c5c80beaf7eb9 ("i2c: Switch to using gpiod interface
> for gpio bus recovery")
>
> Signed-off-by: Phil Reid <preid@electromag.com.au>
> ---
> drivers/i2c/i2c-core-base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index 54ffc8d..bf52cca 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -27,7 +27,7 @@
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/errno.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
Looks like this was masked by CONFIG_GPIOLIB=y.
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2017-11-28 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 3:09 [PATCH 0/2] i2c: fix compile failures Phil Reid
2017-11-28 3:09 ` [PATCH 1/2] i2c: core: fix compile issue related to incorrect gpio header Phil Reid
2017-11-28 9:04 ` Jarkko Nikula [this message]
2017-11-28 9:48 ` Wolfram Sang
2017-11-28 3:09 ` [PATCH 2/2] i2c: designware: fix building driver as module Phil Reid
2017-11-28 8:58 ` Jarkko Nikula
2017-11-28 9:48 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=380c34f9-6501-a11c-b077-670d4a1346aa@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=preid@electromag.com.au \
--cc=sfr@canb.auug.org.au \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).