From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264BBC4338F for ; Wed, 11 Aug 2021 21:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02D546104F for ; Wed, 11 Aug 2021 21:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231956AbhHKVFn (ORCPT ); Wed, 11 Aug 2021 17:05:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhHKVFm (ORCPT ); Wed, 11 Aug 2021 17:05:42 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E65EC061765 for ; Wed, 11 Aug 2021 14:05:18 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id r6so4945410wrt.4 for ; Wed, 11 Aug 2021 14:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gdhycNUF+ZoqVHgszBDw6oGl7UN01EELAVk6uskBiRo=; b=AcDwPM8Gm8Mt9wHjD+1pl+niQuwaF7RjvBJqIZREogHJBPlxFmOmGF+ZetZJzx/r7B rdwE2Hcq/SWXmdhwLK1O+oU02n/ClBxrBMo5dNlmq5kBOOvAFpwhXYQK3WzzBNQnkqHj No3fpUkFu+TgNK9/WmABAWzd25apbbgsoq015yoVqkN0B9zNQ9LhqJBhJT7yZQVJj39D zuoieSc1bQS9cLbHk5kVqWIrA3M/Iq2MmQxkyIOSfkCZu7uAXPWN0aCMHE/0aI6e5rgr dD1D4oP/1BkG4r5JU/Vagv5M3T+0NKUdmcepOQnM0pXAz7x9DA6LN2xY39lvdrkjw12a Jvxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gdhycNUF+ZoqVHgszBDw6oGl7UN01EELAVk6uskBiRo=; b=FBSJSbDRvBtTjCyzpWwvIdxn9TZppnj+9inTXM8aIpcSMrbw+emxGSQ8VS212W8TNj crseoFUyvs49ZEGJjFxodC56CB1ApIJ0fZ3pwcvwLkpQk+dYdYqJwbgXvR9zvUjHNzE+ eegnw2RDcTRUdfSjmgG6/IiVwfGU2NHmLLHBFPUw/tZmmpeSnLbb8iDMWyxXVXJ8mXZx UJpR9fldq/+344oIWphtIhzX3zzLjmvrgDy7fcSRgGZSf3gSUIC3LsNSG7lgXkuZC5ji SUS0WXaloxthINaM/ZYTd5vJmU2NzpvmB6L0feyQ7B1eG25jeRwq3n19fF2G183ERpVC SzEQ== X-Gm-Message-State: AOAM531Wf60nO83IRPCmH7enc+8EoRKEPw11BVOYus8uFlj2+9W0XeLI 0bGABtCtLHx6La6OlMWkPGL6ZIOO56IByw== X-Google-Smtp-Source: ABdhPJymvIFbX66JS3rwbFPMkuD2Ft8/i33oVYUCT9DMS9Dp5zq0TicE9MD3ybrzi8EVAIUlBLEWmQ== X-Received: by 2002:adf:e6cc:: with SMTP id y12mr402302wrm.200.1628715916966; Wed, 11 Aug 2021 14:05:16 -0700 (PDT) Received: from ?IPv6:2003:ea:8f10:c200:988:dfda:c500:b22? (p200300ea8f10c2000988dfdac5000b22.dip0.t-ipconnect.de. [2003:ea:8f10:c200:988:dfda:c500:b22]) by smtp.googlemail.com with ESMTPSA id v17sm555258wro.45.2021.08.11.14.05.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 14:05:16 -0700 (PDT) To: Andy Shevchenko Cc: Jean Delvare , "linux-i2c@vger.kernel.org" References: <90aee333-6490-db08-01ae-c0de1e18368a@gmail.com> From: Heiner Kallweit Subject: Re: [PATCH v2 2/9] i2c: i801: make p2sb_spinlock a mutex Message-ID: <3a35757b-d0f4-fa7b-6946-548782904ab8@gmail.com> Date: Wed, 11 Aug 2021 22:27:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 11.08.2021 17:43, Andy Shevchenko wrote: > On Fri, Aug 06, 2021 at 11:13:29PM +0200, Heiner Kallweit wrote: >> p2sb_spinlock is used in i801_add_tco_spt() only, and in process context >> only. Therefore a mutex is sufficient, and we can make the definition >> local to i801_add_tco_spt(). > > The problem with either AFAICT is that it should actually hold PCI rescan lock. > See the discussion with Message-ID > 20210308122020.57071-1-andriy.shevchenko@linux.intel.com for the details. > Thanks for the link. I see that you use pci_lock_rescan_remove() but at a first glance didn't see this being discussed. Maybe because it's obvious .. i801 was discussed here: https://lore.kernel.org/linux-i2c/20210310155145.513a7165@endymion/ However discussion seems to have ended w/o result. What's the status of your p2sb series? Backgroud of the question is: Does it make sense to wait for your series to be applied, to make use of your new ps2b library functions? Or change the mutex to the rescan mutex for the time being?