From: <Conor.Dooley@microchip.com>
To: <wsa@kernel.org>, <Conor.Dooley@microchip.com>,
<linux-i2c@vger.kernel.org>, <ben.dooks@codethink.co.uk>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<Daire.McNamara@microchip.com>
Subject: Re: [PATCH v6 1/2] i2c: add support for microchip fpga i2c controllers
Date: Wed, 6 Jul 2022 10:50:44 +0000 [thread overview]
Message-ID: <3b2ac34b-7da4-9714-eb65-d62f900c6679@microchip.com> (raw)
In-Reply-To: <YsVk0Gg1x7juHcZU@shikoro>
On 06/07/2022 11:32, Wolfram Sang wrote:
> Where are the bindings? Are they already on the way upstream?
Already upstream.
Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml
>
>> I'd prefer the latter. Being called "core" is unfortunate and I
>> did think about that. i2c-microchip-corei2c would have been my
>> first choice but I thought the double usage of i2c would've been
>> disapproved of haha
>
> :) Well, double "i2c" is not exactly pretty but since it is the name of
> that IP core...
Yeah, and it is the name of /all/ the IP cores we have (:
>
>>>> + if (idev->msg_len <= 0)
>>>> + finished = true;
>>>
>>> How can it happen that len is < 0? Wouldn't that be an error case?
>
> Is it to be on the safe side?
Ahh sorry, I missed that. msg_len is a u16 so cannot be <0
I'll change it.
>
>>> Have you testes SMBUS_QUICK as well?
>>
>> Not specifically SMBUS_QUICK, but I did test with hardware
>> that uses "zero-length" messages.
>
> Good!
>
>> Thanks for the review :)
>
> You are welcome.
>
prev parent reply other threads:[~2022-07-06 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 7:42 [PATCH v6 1/2] i2c: add support for microchip fpga i2c controllers Conor Dooley
2022-06-21 7:42 ` [PATCH v6 2/2] MAINTAINERS: add the polarfire soc's i2c driver Conor Dooley
2022-07-06 7:21 ` Wolfram Sang
2022-07-06 7:41 ` Conor.Dooley
2022-07-06 7:19 ` [PATCH v6 1/2] i2c: add support for microchip fpga i2c controllers Wolfram Sang
2022-07-06 8:03 ` Conor.Dooley
2022-07-06 10:32 ` Wolfram Sang
2022-07-06 10:50 ` Conor.Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b2ac34b-7da4-9714-eb65-d62f900c6679@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).