Re: [PATCH 1/6] dt-bindings: qcom: geni-se: document I2C Master Hub wrapper variant

Krzysztof Kozlowski
2022-11-17T14:44:07Z

On 16/11/2022 11:21, Neil Armstrong wrote:
> The I2C Master Hub is a stripped down version of the GENI Serial Engine
> QUP Wrapper Controller but only supporting I2C serial engines without
> DMA support.
>
> This documents the variant compatible and forbids UART and SPI sub-nodes,

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> and removes requirement for the Master AHB clock and iommu property.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 43 ++++++++++++++++++----
> 1 file changed, 35 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> index 2bf5293fc995..6657e74df629 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> @@ -21,20 +21,15 @@ properties:
> compatible:
> enum:
> - qcom,geni-se-qup
> + - qcom,geni-se-i2c-master-hub
>
> reg:
> description: QUP wrapper common register address and length.
> maxItems: 1
>
> - clock-names:
> - items:
> - - const: m-ahb
> - - const: s-ahb
> + clock-names: true

minItems: 1, maxItems: 2, instead.

>
> - clocks:
> - items:
> - - description: Master AHB Clock
> - - description: Slave AHB Clock
> + clocks: true

minItems: 1, maxItems: 2, instead.

>
> "#address-cells":
> const: 2
> @@ -81,6 +76,38 @@ patternProperties:
> description: GENI Serial Engine based UART Controller.
> $ref: /schemas/serial/qcom,serial-geni-qcom.yaml#
>
> +if:

Put it under allOf, to avoid re-indenting when number of if's grow.

> + properties:
> + compatible:
> + contains:
> + const: qcom,geni-se-i2c-master-hub
>

Best regards,
Krzysztof