Re: [PATCH 2/6] dt-bindings: i2c: qcom-geni: document I2C Master Hub serial I2C engine

Krzysztof Kozlowski
2022-11-17T14:45:03Z

On 16/11/2022 11:21, Neil Armstrong wrote:
> The I2C Master Hub is a stripped down version of the GENI Serial Engine
> QUP Wrapper Controller but only supporting I2C serial engines without
> DMA support.
>
> This documents the I2C Serial Engine variant used within the I2C Master
> Hub Wrapper. This serial engine variant lacks DMA support, and requires
> a core clock, and since DMA support is lacking, the memory interconnect
> path isn't needed.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 61 +++++++++++++++++-----
> 1 file changed, 49 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> index 0e7ed00562e2..ea2c28e70cf5 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> @@ -15,13 +15,13 @@ allOf:
>
> properties:
> compatible:
> - const: qcom,geni-i2c
> + enum:
> + - qcom,geni-i2c
> + - qcom,geni-i2c-master-hub
>
> - clocks:
> - maxItems: 1
> + clocks: true
>
> - clock-names:
> - const: se
> + clock-names: true
>

Same comments as in previous patch.

Best regards,
Krzysztof