From: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Carlos Palminha" <CARLOS.PALMINHA@synopsys.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i2c-piix4: several coding style fixes
Date: Fri, 14 Oct 2016 12:52:50 +0100 [thread overview]
Message-ID: <3c9ba6ec-c137-fa3c-7b5b-7ea7ed58e865@synopsys.com> (raw)
In-Reply-To: <20161014070825.qlawh2ttlwj24jge@pengutronix.de>
On 14-10-2016 08:08, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Oct 13, 2016 at 11:39:01PM +0100, Carlos Palminha wrote:
>> @@ -196,7 +204,7 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
>> } else {
>> pci_read_config_word(PIIX4_dev, SMBBA, &piix4_smba);
>> piix4_smba &= 0xfff0;
>> - if(piix4_smba == 0) {
>> + if (piix4_smba == 0) {
>> dev_err(&PIIX4_dev->dev, "SMBus base address "
>> "uninitialized - upgrade BIOS or use "
>> "force_addr=0xaddr\n");
>
> did you left this message in three lines on purpose?
>
Hi Uwe,
There were some missing lines. I had some doubts regarding if the
"quoted string" could go with more than 80 chars. I see now that
checkpatch is ok.
I'll resend a v3.
> Best regards
> Uwe
>
Regards,
C.Palminha
prev parent reply other threads:[~2016-10-14 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 22:39 [PATCH v2] i2c: i2c-piix4: several coding style fixes Carlos Palminha
2016-10-14 7:08 ` Uwe Kleine-König
2016-10-14 11:52 ` Carlos Palminha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9ba6ec-c137-fa3c-7b5b-7ea7ed58e865@synopsys.com \
--to=carlos.palminha@synopsys.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).