From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Subject: Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly Date: Fri, 14 Sep 2018 09:52:35 -0700 Message-ID: <3e319dd0-17e6-679d-18fd-43ed59f7075d@linux.intel.com> References: <20180911233302.GA18799@roeck-us.net> <5698ca34-14c9-8d05-c4e6-5acf85ff9d14@linux.intel.com> <20180912013449.GA12612@roeck-us.net> <7fd98646-fb5a-be4d-ce37-84b74e0fa8b3@linux.intel.com> <20180912195844.GA6893@roeck-us.net> <20180912203059.GA18201@roeck-us.net> <3f86e75f-1502-eae8-0633-d087937111c8@roeck-us.net> <20180913155703.GA22605@roeck-us.net> <2c481986-7ee0-4887-5c9b-64e2cd9d8c04@kaod.org> <94a2aa4e-69ac-7042-92d9-1ada46d5fc33@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <94a2aa4e-69ac-7042-92d9-1ada46d5fc33@roeck-us.net> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Guenter Roeck , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: linux-aspeed@lists.ozlabs.org, James Feist , Vernon Mauery , OpenBMC Maillist , Brendan Higgins , Linux Kernel Mailing List , jarkko.nikula@linux.intel.com, Linux ARM , linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 9/14/2018 6:23 AM, Guenter Roeck wrote: > On 09/13/2018 10:38 PM, Cédric Le Goater wrote: >>>>> That seems to suggest that none of the status bits auto-clears, and >>>>> that >>>>> the above code clearing intr_status should be removed entirely. >>>>> Am I missing something ? >>>> >>>> You are right. I just pushed another version of the previous patch >>>> with this >>>> new hunk : >>>> >>>> @@ -188,7 +200,6 @@ static void aspeed_i2c_bus_handle_cmd(As >>>>    { >>>>        bus->cmd &= ~0xFFFF; >>>>        bus->cmd |= value & 0xFFFF; >>>> -    bus->intr_status = 0; >>>>          if (bus->cmd & I2CD_M_START_CMD) { >>>>            uint8_t state = aspeed_i2c_get_state(bus) & I2CD_MACTIVE ? >>>> >>>> >>>> The QEMU palmetto and witherspoon machines seem to behave fine. Can >>>> you give >>>> it a try ? >>>> >>> >>> Works fine for me for all affected qemu platforms. >>> >>> How do you want to proceed with the qemu patches ? I attached my patches >>> for reference. Maybe you can add them to your tree if they are ok and >>> submit >>> the entire series together to the qemu mailing list ? >> >> yes. They are pushed in my aspeed-3.1 branch. I will send the series >> on the list. >> > > Excellent. Thanks a lot! > > Guenter > Awesome! Many thanks to Guenter, Cédric and Joel. I really appreciate it. Jae