From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bitan Biswas Subject: Re: [PATCH V5] drivers: i2c: tegra: fix warning/check/error Date: Fri, 7 Jun 2019 04:43:26 -0700 Message-ID: <3f63d2b4-ef78-4d36-e369-a55fc9b7c205@nvidia.com> References: <1559885103-9113-1-git-send-email-bbiswas@nvidia.com> <20190607060358.GB1035@kunai> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190607060358.GB1035@kunai> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Laxman Dewangan , Thierry Reding , Jonathan Hunter , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Shardar Mohammed , Sowjanya Komatineni , Mantravadi Karthik List-Id: linux-i2c@vger.kernel.org On 6/6/19 11:03 PM, Wolfram Sang wrote: > On Thu, Jun 06, 2019 at 10:25:03PM -0700, Bitan Biswas wrote: >> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >> >> Ignore checkpatch WARNING for 80 character line limit at >> places where renaming fields compromises readability. >> >> Delay of approximately 1msec in flush i2c FIFO polling loop >> achieved by usleep_range call as msleep can take 20msecs. >> >> Remove redundant BUG_ON calls or replace with WARN_ON_ONCE >> as needed. Replace BUG() with error handling code. >> Define I2C_ERR_UNEXPECTED_STATUS for error handling. > > You removed the word checkpatch from $subject, but you still did not > split up the patch into logical pieces. The description above already > outlines what those logical pieces could be. > I shall split the patch into multiple logical patches. -Thanks, Bitan