From: Thor Thayer <thor.thayer@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
andy.shevchenko@gmail.com, davem@davemloft.net,
gregkh@linuxfoundation.org, mchehab@kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [[RESEND]PATCHv6 2/2] i2c: altera: Add Altera I2C Controller driver
Date: Mon, 18 Sep 2017 15:04:34 -0500 [thread overview]
Message-ID: <3f9fe0a6-0e8d-7038-28e6-eacc6ed2e7ad@linux.intel.com> (raw)
In-Reply-To: <20170913205038.ndlkaivkdgxa3ee2@ninjato>
On 09/13/2017 03:50 PM, Wolfram Sang wrote:
> On Mon, Sep 11, 2017 at 04:17:20PM -0500, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add driver support for the Altera I2C Controller. The I2C
>> controller is soft IP for use in FPGAs.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> ---
>
> Applied to for-next (will be in v4.14), thanks!
>
>> + if (finish) {
>> + /* Wait for the Core to finish */
>> + ret = readl_poll_timeout_atomic(idev->base + ALTR_I2C_STATUS,
>
> I wonder a bit about polling in an interrupt handler (maybe threaded
> irqs?) but we can fix that later, I think.
>
Yes, based on your previous feedback, I changed to a threaded IRQ as
shown below. The altr_i2c_isr_quick wakes up this IRQ handler if the
status is non-zero.
+
+ ret = devm_request_threaded_irq(&pdev->dev, irq, altr_i2c_isr_quick,
+ altr_i2c_isr, IRQF_ONESHOT,
+ pdev->name, idev);
Thanks for the review and applying the patch!
next prev parent reply other threads:[~2017-09-18 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 21:17 [[RESEND]PATCHv6 1/2] dt-bindings: i2c: Add Altera I2C Controller thor.thayer
[not found] ` <1505164640-26413-1-git-send-email-thor.thayer-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-09-11 21:17 ` [[RESEND]PATCHv6 2/2] i2c: altera: Add Altera I2C Controller driver thor.thayer-VuQAYsv1563Yd54FQh9/CA
2017-09-13 20:50 ` Wolfram Sang
2017-09-18 20:04 ` Thor Thayer [this message]
2017-09-13 21:28 ` Wolfram Sang
2017-09-13 20:50 ` [[RESEND]PATCHv6 1/2] dt-bindings: i2c: Add Altera I2C Controller Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f9fe0a6-0e8d-7038-28e6-eacc6ed2e7ad@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).