From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4 1/2] i2c: qup: add ACPI support Date: Thu, 30 Jun 2016 13:52:56 +0200 Message-ID: <4043322.Uc6lMkrL43@wuerfel> References: <1465409985-17113-1-git-send-email-austinwc@codeaurora.org> <4749471.m1cxc4jj96@wuerfel> <577503F2.90204@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.17.13]:56482 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858AbcF3Lu7 (ORCPT ); Thu, 30 Jun 2016 07:50:59 -0400 In-Reply-To: <577503F2.90204@codeaurora.org> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Christopher Covington Cc: linux-arm-kernel@lists.infradead.org, Austin Christ , wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, timur@codeaurora.org, rruigrok@codeaurora.org, nkaje@codeaurora.org On Thursday, June 30, 2016 7:35:14 AM CEST Christopher Covington wrote: > Hi Arnd, > > On 06/08/2016 05:02 PM, Arnd Bergmann wrote: > > On Wednesday, June 8, 2016 12:19:44 PM CEST Austin Christ wrote: > >> + ret = device_property_read_u32(qup->dev, > >> + "src-clock-hz", &src_clk_freq); > >> + if (ret) { > >> + dev_warn(qup->dev, "using default src-clock-hz %d", > >> + DEFAULT_SRC_CLK); > >> + src_clk_freq = DEFAULT_SRC_CLK; > >> + } > >> > > > > Where is this property documented? > > We plan on submitting documentation via dsd@acpica.org to > https://github.com/ahs3/dsd once it is operational. As I understand it > the project is brand new. It may take several months to begin accepting > submissions. In the mean time, we could potentially include > documentation in a reply to this thread, the cover of the next series, a > wiki page on codeaurora.org, a file in Documentation (perhaps to be > replaced by ACPICA style imports of the OS-neutral DSD project or a git > submodule) or potentially other means. Please let us know what you think > is sufficient. As you are reusing part of the DT binding, it seems appropriate to put the documentation for this into the binding documentation in the kernel. Not sure what the devicetree maintainers think about that though. Arnd