From: Markus Elfring <Markus.Elfring@web.de>
To: "Triet Hoang" <triet.hoang.dev@gmail.com>,
linux-i2c@vger.kernel.org, "Andi Shyti" <andi.shyti@kernel.org>,
"Bence Csókás" <bence98@sch.bme.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: cp2615: Validate read length before copying
Date: Wed, 19 Aug 2026 10:16:32 +0200 [thread overview]
Message-ID: <40e4c72e-5bc2-4663-b39e-bf6f140c0d54@web.de> (raw)
In-Reply-To: <20260818124737.64478-1-triet.hoang.dev@gmail.com>
…
> Limit read_len to the maximum size of the response buffer and return
> -EPROTO for an invalid response.
* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
* Please avoid duplicate source code also for improved implementations of
functions like cp2615_i2c_recv().
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.2#n526
https://elixir.bootlin.com/linux/v7.2/source/drivers/i2c/busses/i2c-cp2615.c#L138-L169
* How do you think about to increase the application of scope-based resource management?
Regards,
Markus
next prev parent reply other threads:[~2026-08-19 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 12:47 [PATCH] i2c: cp2615: Validate read length before copying Triet Hoang
2026-08-19 8:16 ` Markus Elfring [this message]
2026-08-20 11:57 ` Andi Shyti
2026-08-20 15:40 ` Triet Hoang
2026-08-21 8:43 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40e4c72e-5bc2-4663-b39e-bf6f140c0d54@web.de \
--to=markus.elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=bence98@sch.bme.hu \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=triet.hoang.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox