From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: aisheng.dong@nxp.com, andi.shyti@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, carlos.song@nxp.com
Subject: Re: [PATCH 5/5] i2c: imx-lpi2c: increase PM timeout to avoid operate clk frequently
Date: Thu, 29 Aug 2024 12:55:16 +0200 [thread overview]
Message-ID: <4375906.ejJDZkT8p0@steina-w> (raw)
In-Reply-To: <20240829093722.2714921-5-carlos.song@nxp.com>
Hi,
Am Donnerstag, 29. August 2024, 11:37:22 CEST schrieb carlos.song@nxp.com:
> From: Clark Wang <xiaoning.wang@nxp.com>
>
> Switching the clock frequently will affect the data transmission
> efficiency, and prolong the timeout to reduce autosuspend times for
> lpi2c.
Efficiency as in throughput or total time per transfer? Do you have any
numbers?
Best regards,
Alexander
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> ---
> drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
> index 210d505db76d..cc5e5d96aacd 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -129,7 +129,7 @@
> #define I2C_CLK_RATIO 2
> #define CHUNK_DATA 256
>
> -#define I2C_PM_TIMEOUT 10 /* ms */
> +#define I2C_PM_TIMEOUT 1000 /* ms */
> #define I2C_DMA_THRESHOLD 8 /* bytes */
>
> enum lpi2c_imx_mode {
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2024-08-29 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 9:37 [PATCH 1/5] i2c: imx-lpi2c: add target mode support carlos.song
2024-08-29 9:37 ` [PATCH 2/5] i2c: imx-lpi2c: add IRQF_NO_SUSPEND IRQ flag carlos.song
2024-08-29 10:52 ` Stefan Wahren
2024-08-30 8:53 ` [EXT] " Carlos Song
2024-08-29 9:37 ` [PATCH 3/5] i2c: imx-lpi2c: manage IRQ request/release in runtime pm carlos.song
2024-08-29 9:37 ` [PATCH 4/5] i2c: imx-lpi2c: improve i2c driver probe priority carlos.song
2024-08-29 10:16 ` Stefan Wahren
2024-08-30 8:53 ` [EXT] " Carlos Song
2024-08-29 9:37 ` [PATCH 5/5] i2c: imx-lpi2c: increase PM timeout to avoid operate clk frequently carlos.song
2024-08-29 10:55 ` Alexander Stein [this message]
2024-08-30 8:53 ` [EXT] " Carlos Song
2024-08-30 9:07 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4375906.ejJDZkT8p0@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=aisheng.dong@nxp.com \
--cc=andi.shyti@kernel.org \
--cc=carlos.song@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).