From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B31114AEF0 for ; Sun, 7 Jul 2024 16:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720371333; cv=none; b=UEuzJDt0ATtFYcr09XGu7BN32tbXHOOoQU4zbmNAVcTyMvKROTOpRdYtflhXUfTdeoeNwP0dgulHZS4Jzmw6YqOBfXoVd361Mg+Ms6BTh6q4dytSt6mA516QsCLZ9JeBwu7B10PLWsXDX0PHtz/qWNRdfeO9HL12tyxeMqJyfhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720371333; c=relaxed/simple; bh=CzbVOsWDdWpkYHY5sfVvV82wwbI1wiksNM9TRD668Io=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KVI6HFOI1VScv5z2R5WbqVHe4K+1+O2Z2+GxhCKVUbLbsUYhu7XVJYm9OAof+UGeyJ/sHM6P/sGZbF4ASpRYvPkzXyU3ZvjhUAH3XvH7VQyp5vk5B+QaG76oxgRpQW5RM44qaG6KzuWN9F0Scb6hfmPrXAJgJgnijvKDkwV1lR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ma1lEBro; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ma1lEBro" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720371329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yUgn9zeh8Lf45LE8ye9A2hP/w2XRLDsyivf0TMqWYOQ=; b=Ma1lEBroo221dOLw59wnhN9SFDD1WsK7Dctu9gkXpTlr9Loj51OQuSGGbU80VsG7n8WTvx 7oNN9wMy9oGwcpK7sxG7hTEb1z43Op2fD1CPv0ur+4yHwKkuNuL5zgUw/B/N/tcN+IOB+r Tl7a5YauErOqJRtWFIG194nI8TwVGeQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-E_TAG6DSOPuYeb8IkAr0lA-1; Sun, 07 Jul 2024 12:55:28 -0400 X-MC-Unique: E_TAG6DSOPuYeb8IkAr0lA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a77f36785ceso32988666b.1 for ; Sun, 07 Jul 2024 09:55:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720371327; x=1720976127; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yUgn9zeh8Lf45LE8ye9A2hP/w2XRLDsyivf0TMqWYOQ=; b=sc7QQQnq0OVb/9V6+JgWkS+r5e2O8TAvwOzxQdUONi9Cb4t6GY5zzaGUQrOlrU7hlj pU3DqDY4SLa7yviuI8tpEafOrBqcW5wHpPSNqClGgXWd6f1AnG38qdrWX7hto2zaxrut KH+ppWjvcJcEovvRwaWAs+l+aPrNNap3BxEsENyIr6pSDRWFTt8iQmAtzVtteP2EotgA tFhpv6iOQS6OjEzi2OF/rrPUgYJi3VYc5oOX9meWfcxnpqtzRJqAswkxFZYG/tDsj6eT XUPPSctooSQWSYHSHqgISflHeCY5pb7TG3RP0eaVEnMJDtCJlGvlw1FojHlfP5M68OyL DQ1g== X-Forwarded-Encrypted: i=1; AJvYcCVmwKMqrKv7tv9z7rpqfpsCztyD4naBRxXUif/1/bapdze1wPsDtGaw64iuLYY7l5Gn2YCVdnLyU9k7Z0o1NsGyqWCfOKBbrxlq X-Gm-Message-State: AOJu0Yw0PS5EQTOyLyzgLIHoWWTk7J8ZLbwS+7udLqpY7VT341p/V/ta sJtQI9YhQm/Y7IJCf1v2T1xetzSjU2Q/KZlyjWx0Q+aPbnleAcFsa3qNdSW2w6tpA04c5OFwSo0 u/woQSCaBU4kWWeYnemjDj3fCQ8GKu8zqP9hjoOYLteP+kbcOLVJhp2IQgCTJyjL60w== X-Received: by 2002:a17:906:4556:b0:a72:6375:5fa7 with SMTP id a640c23a62f3a-a77ba72c53fmr602034766b.64.1720371326957; Sun, 07 Jul 2024 09:55:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFZghCTEp8O1D4E9CQS4aEDj/nt+bdk+H5qZ1uBdFM9K2g1BWsNpr3q2zu1OC5myUFW2bNng== X-Received: by 2002:a17:906:4556:b0:a72:6375:5fa7 with SMTP id a640c23a62f3a-a77ba72c53fmr602033666b.64.1720371326491; Sun, 07 Jul 2024 09:55:26 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77df94aa5dsm165941066b.130.2024.07.07.09.55.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jul 2024 09:55:25 -0700 (PDT) Message-ID: <472cb530-b5d7-4ef2-a279-16fdbf07a014@redhat.com> Date: Sun, 7 Jul 2024 18:55:24 +0200 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/60] i2c: cht-wc: reword according to newest specification To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Andi Shyti , linux-kernel@vger.kernel.org References: <20240706112116.24543-1-wsa+renesas@sang-engineering.com> <20240706112116.24543-9-wsa+renesas@sang-engineering.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240706112116.24543-9-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 7/6/24 1:20 PM, Wolfram Sang wrote: > Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 > specifications and replace "master/slave" with more appropriate terms. > > Signed-off-by: Wolfram Sang > Reviewed-by: Andi Shyti Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/i2c/busses/i2c-cht-wc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c > index 0209933b9a84..52e3000626c5 100644 > --- a/drivers/i2c/busses/i2c-cht-wc.c > +++ b/drivers/i2c/busses/i2c-cht-wc.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > /* > - * Intel CHT Whiskey Cove PMIC I2C Master driver > + * Intel CHT Whiskey Cove PMIC I2C controller driver > * Copyright (C) 2017 Hans de Goede > * > * Based on various non upstream patches to support the CHT Whiskey Cove PMIC: > @@ -106,7 +106,7 @@ static irqreturn_t cht_wc_i2c_adap_thread_handler(int id, void *data) > return IRQ_HANDLED; > } > > -static u32 cht_wc_i2c_adap_master_func(struct i2c_adapter *adap) > +static u32 cht_wc_i2c_adap_func(struct i2c_adapter *adap) > { > /* This i2c adapter only supports SMBUS byte transfers */ > return I2C_FUNC_SMBUS_BYTE_DATA; > @@ -168,7 +168,7 @@ static int cht_wc_i2c_adap_smbus_xfer(struct i2c_adapter *_adap, u16 addr, > } > > static const struct i2c_algorithm cht_wc_i2c_adap_algo = { > - .functionality = cht_wc_i2c_adap_master_func, > + .functionality = cht_wc_i2c_adap_func, > .smbus_xfer = cht_wc_i2c_adap_smbus_xfer, > }; > > @@ -554,6 +554,6 @@ static struct platform_driver cht_wc_i2c_adap_driver = { > }; > module_platform_driver(cht_wc_i2c_adap_driver); > > -MODULE_DESCRIPTION("Intel CHT Whiskey Cove PMIC I2C Master driver"); > +MODULE_DESCRIPTION("Intel CHT Whiskey Cove PMIC I2C controller driver"); > MODULE_AUTHOR("Hans de Goede "); > MODULE_LICENSE("GPL");