From: Marc Dietrich <marvin24@gmx.de>
To: Andrey Danin <danindrey@mail.ru>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, ac100@lists.launchpad.net,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Julian Andres Klode <jak@jak-linux.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-i2c@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
linux-tegra@vger.kernel.org, devel@linuxdriverproject.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Alexandre Courbot <gnurou@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
Date: Tue, 21 Jul 2015 10:25:31 +0200 [thread overview]
Message-ID: <4778199.vGjAP5lpOS@fb07-iapwap2> (raw)
In-Reply-To: <55ADE829.4030108@mail.ru>
[-- Attachment #1.1: Type: text/plain, Size: 1132 bytes --]
Am Dienstag, 21. Juli 2015, 09:35:21 schrieb Andrey Danin:
> On 21.07.2015 1:19, Stephen Warren wrote:
> > On 07/20/2015 02:35 PM, Andrey Danin wrote:
> >> NVEC driver was reimplemented to use tegra i2c. Use common i2c bindings
> >> for NVEC node.
> >>
> >> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> >> b/arch/arm/boot/dts/tegra20-paz00.dts
> >>
> >> + nvec: nvec@45 {
> >> + compatible = "nvidia,nvec-slave";
> >> + reg = <0x45>;
> >
> > I think you need to or in I2C_OWN_SLAVE_ADDRESS from
> > <dt-bindings/i2c/i2c.h> here?
>
> Sorry, I mentioned it in letter 0 only.
> I will rework nvec driver and device tree according to i2c core slave
> implementation later. v3 of this patchset is for fixing tegra i2c driver
> only.
I think in this case it would be better to leave nvec and dt as it is for now,
and just add the slave function to tegra-i2c. Otherwise we will again have two
different "nvidia,nvec-slave" bindings (one for the intermediate hack and one
for the final representation). As an alternative, you could also add slave
function and port nvec in the same series.
Marc
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2015-07-21 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 20:35 [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
[not found] ` <1437424546-30405-1-git-send-email-danindrey-JGs/UdohzUI@public.gmane.org>
2015-07-20 20:35 ` [PATCH v3 1/4] i2c: tegra: implement slave mode Andrey Danin
2015-07-24 9:27 ` Wolfram Sang
2015-07-24 10:18 ` Andrey Danin
[not found] ` <55B210F4.6030700-JGs/UdohzUI@public.gmane.org>
2015-07-24 10:52 ` Wolfram Sang
2015-08-20 12:14 ` Andrey Danin
[not found] ` <55D5C4AA.2000307-JGs/UdohzUI@public.gmane.org>
2015-09-08 11:46 ` Wolfram Sang
2015-09-08 12:31 ` Andrey Danin
2015-07-20 20:35 ` [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver Andrey Danin
[not found] ` <1437424546-30405-3-git-send-email-danindrey-JGs/UdohzUI@public.gmane.org>
2015-07-20 22:18 ` Stephen Warren
2015-07-20 20:35 ` [PATCH v3 3/4] staging/nvec: remove old code Andrey Danin
2015-07-20 20:35 ` [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus Andrey Danin
2015-07-20 22:19 ` Stephen Warren
[not found] ` <55AD73F4.2050502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-07-21 6:35 ` Andrey Danin
2015-07-21 8:25 ` Marc Dietrich [this message]
2015-07-21 8:51 ` Andrey Danin
[not found] ` <55AE0803.10603-JGs/UdohzUI@public.gmane.org>
2015-07-21 11:57 ` Marc Dietrich
2015-07-21 20:52 ` Wolfram Sang
2015-07-21 8:38 ` [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4778199.vGjAP5lpOS@fb07-iapwap2 \
--to=marvin24@gmx.de \
--cc=ac100@lists.launchpad.net \
--cc=danindrey@mail.ru \
--cc=devel@linuxdriverproject.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jak@jak-linux.org \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).