Re: [patch 6/6] Minor fixes for pxa-driver

[Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>]

Jean Delvare wrote:
> Hi Wolfram,
> 
> On Mon, 21 Jan 2008 15:20:16 +0100, w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org wrote:
>> While working on the PCA9564-platform driver, I sometimes had a glimpse at the
>> pxa-driver. I found some suspicious places, and this patch contains my
>> suggestions. Note: They are not tested, due to no hardware.
> 
> Looks good. I've added a couple more fixes, resulting patch is below.
> As I don't have hardware for testing either, I would appreciate if
> someone with a PXA board could test it and confirm that it causes no
> regression. Mike? Eric? I plan to send this patch to Linus for 2.6.25
> (i.e. quickly.)

This patch doesn't apply on top of Linus' tree most probably due
to a conflict with this patch by Eric Miao:

http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/i2c-pxa-use-cpu_is_pxa27x.patch

Except that, it seems to be Ok, at least with the hardware I have.


> From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Subject: i2c-pxa: Misc fixes
> 
> While working on the PCA9564-platform driver, I sometimes had a glimpse at the
> pxa-driver. I found some suspicious places, and this patch contains my
> suggestions. Note: They are not tested, due to no hardware.
> 

[ snip ]



-- 
Sincerely yours,
Mike.


_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c