* COMPLETE is a poor global identifier
@ 2008-03-28 10:24 Andrew Morton
[not found] ` <20080328032449.cbc09f3b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-03-28 10:24 UTC (permalink / raw)
To: i2c, netdev; +Cc: Jiri Slaby
powerpc allmodconfig:
In file included from drivers/char/rio/rio_linux.c:81:
drivers/char/rio/cirrus.h:202:1: warning: "COMPLETE" redefined
In file included from include/net/netns/ipv4.h:8,
from include/net/net_namespace.h:13,
from include/linux/seq_file.h:7,
from include/asm/machdep.h:12,
from include/asm/pci.h:17,
from include/linux/pci.h:951,
from drivers/char/rio/rio_linux.c:50:
include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
In file included from drivers/char/ip2/ip2main.c:128:
drivers/char/ip2/i2ellis.h:608:1: warning: "COMPLETE" redefined
In file included from include/net/netns/ipv4.h:8,
from include/net/net_namespace.h:13,
from include/linux/seq_file.h:7,
from include/asm/machdep.h:12,
from include/asm/pci.h:17,
from include/linux/pci.h:951,
from drivers/char/ip2/ip2main.c:95:
include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
they should all be renamed. These can cause runtime failures, so it's not
a trivial thing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: COMPLETE is a poor global identifier
[not found] ` <20080328032449.cbc09f3b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
@ 2008-03-28 14:38 ` Jean Delvare
2008-03-28 17:53 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Jean Delvare @ 2008-03-28 14:38 UTC (permalink / raw)
To: Andrew Morton
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, i2c-GZX6beZjE8VD60Wz+7aTrA,
Jiri Slaby
Hi Andrew,
On Fri, 28 Mar 2008 03:24:49 -0700, Andrew Morton wrote:
>
> powerpc allmodconfig:
>
> In file included from drivers/char/rio/rio_linux.c:81:
> drivers/char/rio/cirrus.h:202:1: warning: "COMPLETE" redefined
> In file included from include/net/netns/ipv4.h:8,
> from include/net/net_namespace.h:13,
> from include/linux/seq_file.h:7,
> from include/asm/machdep.h:12,
> from include/asm/pci.h:17,
> from include/linux/pci.h:951,
> from drivers/char/rio/rio_linux.c:50:
> include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
>
> In file included from drivers/char/ip2/ip2main.c:128:
> drivers/char/ip2/i2ellis.h:608:1: warning: "COMPLETE" redefined
> In file included from include/net/netns/ipv4.h:8,
> from include/net/net_namespace.h:13,
> from include/linux/seq_file.h:7,
> from include/asm/machdep.h:12,
> from include/asm/pci.h:17,
> from include/linux/pci.h:951,
> from drivers/char/ip2/ip2main.c:95:
> include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
>
>
> they should all be renamed. These can cause runtime failures, so it's not
> a trivial thing.
How is this related to i2c?
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: COMPLETE is a poor global identifier
2008-03-28 14:38 ` Jean Delvare
@ 2008-03-28 17:53 ` Andrew Morton
2008-03-28 18:08 ` Jiri Slaby
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-03-28 17:53 UTC (permalink / raw)
To: Jean Delvare; +Cc: i2c, netdev, Jiri Slaby
On Fri, 28 Mar 2008 15:38:33 +0100 Jean Delvare <khali@linux-fr.org> wrote:
> Hi Andrew,
>
> On Fri, 28 Mar 2008 03:24:49 -0700, Andrew Morton wrote:
> >
> > powerpc allmodconfig:
> >
> > In file included from drivers/char/rio/rio_linux.c:81:
> > drivers/char/rio/cirrus.h:202:1: warning: "COMPLETE" redefined
> > In file included from include/net/netns/ipv4.h:8,
> > from include/net/net_namespace.h:13,
> > from include/linux/seq_file.h:7,
> > from include/asm/machdep.h:12,
> > from include/asm/pci.h:17,
> > from include/linux/pci.h:951,
> > from drivers/char/rio/rio_linux.c:50:
> > include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
> >
> > In file included from drivers/char/ip2/ip2main.c:128:
> > drivers/char/ip2/i2ellis.h:608:1: warning: "COMPLETE" redefined
> > In file included from include/net/netns/ipv4.h:8,
> > from include/net/net_namespace.h:13,
> > from include/linux/seq_file.h:7,
> > from include/asm/machdep.h:12,
> > from include/asm/pci.h:17,
> > from include/linux/pci.h:951,
> > from drivers/char/ip2/ip2main.c:95:
> > include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
> >
> >
> > they should all be renamed. These can cause runtime failures, so it's not
> > a trivial thing.
>
> How is this related to i2c?
uh, I guess at 3:24AM ip2 and i2c look the same.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: COMPLETE is a poor global identifier
2008-03-28 17:53 ` Andrew Morton
@ 2008-03-28 18:08 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2008-03-28 18:08 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jean Delvare, i2c, netdev
On 03/28/2008 06:53 PM, Andrew Morton wrote:
> On Fri, 28 Mar 2008 15:38:33 +0100 Jean Delvare <khali@linux-fr.org> wrote:
>
>> Hi Andrew,
>>
>> On Fri, 28 Mar 2008 03:24:49 -0700, Andrew Morton wrote:
>>> powerpc allmodconfig:
>>>
>>> In file included from drivers/char/rio/rio_linux.c:81:
>>> drivers/char/rio/cirrus.h:202:1: warning: "COMPLETE" redefined
>>> In file included from include/net/netns/ipv4.h:8,
>>> from include/net/net_namespace.h:13,
>>> from include/linux/seq_file.h:7,
>>> from include/asm/machdep.h:12,
>>> from include/asm/pci.h:17,
>>> from include/linux/pci.h:951,
>>> from drivers/char/rio/rio_linux.c:50:
>>> include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
>>>
>>> In file included from drivers/char/ip2/ip2main.c:128:
>>> drivers/char/ip2/i2ellis.h:608:1: warning: "COMPLETE" redefined
>>> In file included from include/net/netns/ipv4.h:8,
>>> from include/net/net_namespace.h:13,
>>> from include/linux/seq_file.h:7,
>>> from include/asm/machdep.h:12,
>>> from include/asm/pci.h:17,
>>> from include/linux/pci.h:951,
>>> from drivers/char/ip2/ip2main.c:95:
>>> include/net/inet_frag.h:28:1: warning: this is the location of the previous definition
>>>
>>>
>>> they should all be renamed. These can cause runtime failures, so it's not
>>> a trivial thing.
>> How is this related to i2c?
>
> uh, I guess at 3:24AM ip2 and i2c look the same.
I'll take care of both, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-28 18:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-28 10:24 COMPLETE is a poor global identifier Andrew Morton
[not found] ` <20080328032449.cbc09f3b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-03-28 14:38 ` Jean Delvare
2008-03-28 17:53 ` Andrew Morton
2008-03-28 18:08 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox