From: Peter Rosin <peda@axentia.se>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Sven Van Asbroeck <svendev@arcx.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] eeprom: at24: don't assign the i2c ID table to at24_driver
Date: Wed, 11 Apr 2018 12:12:54 +0200 [thread overview]
Message-ID: <47dab3e5-1232-dbaf-2dc0-d71d83ef8d38@axentia.se> (raw)
In-Reply-To: <CAMRc=Me66c+ySsmU9bePG7KFU1sTH0OHTfoxrxC_z6Txbu3tqQ@mail.gmail.com>
On 2018-04-11 12:09, Bartosz Golaszewski wrote:
> 2018-04-11 11:56 GMT+02:00 Peter Rosin <peda@axentia.se>:
>> On 2018-04-10 15:12, Bartosz Golaszewski wrote:
>>> We switched to using probe_new(), so this is no longer used
>>> by i2c core.
>>
>> It seems to be used in i2c_device_match() ???
>>
>> This could easily be me not understanding something...
>>
>
> Yes, but i2c core no longer uses the id_table field in struct
> i2c_driver. We call i2c_device_match() ourselves instead of letting
> i2c core do it and pass the driver data to probe().
>
> Hope that helps,
> Bartosz
>
But, i2c_device_match is a static function in the core. I think you
are confusing it with i2c_match_id, which is in fact called from
the static i2c_device_match (with is a bus operation).
So, no, it didn't really help...
Cheers,
Peter
next prev parent reply other threads:[~2018-04-11 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 13:12 [PATCH 0/4] eeprom: at24: last bits of the big refactoring Bartosz Golaszewski
2018-04-10 13:12 ` [PATCH 1/4] eeprom: at24: don't assign the i2c ID table to at24_driver Bartosz Golaszewski
2018-04-11 9:56 ` Peter Rosin
2018-04-11 10:09 ` Bartosz Golaszewski
2018-04-11 10:12 ` Peter Rosin [this message]
2018-04-10 13:12 ` [PATCH 2/4] eeprom: at24: use devm_nvmem_register() Bartosz Golaszewski
2018-04-10 13:12 ` [PATCH 3/4] eeprom: at24: provide and use a helper for releasing dummy i2c clients Bartosz Golaszewski
2018-04-10 13:12 ` [PATCH 4/4] eeprom: at24: provide a separate routine for creating " Bartosz Golaszewski
2018-04-11 11:44 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47dab3e5-1232-dbaf-2dc0-d71d83ef8d38@axentia.se \
--to=peda@axentia.se \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svendev@arcx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).