From: Dan Carpenter <dan.carpenter@linaro.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: dmitry.baryshkov@linaro.org,
Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Liao Chang <liaochang1@huawei.com>,
Todor Tomov <todor.too@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
error27@gmail.com, vegard.nossum@oracle.com
Subject: Re: [PATCH next] i2c: qcom-cci: Fix error checking in cci_probe()
Date: Tue, 5 Sep 2023 12:10:31 +0300 [thread overview]
Message-ID: <47e3acac-7d4f-43bd-bd55-5ae9ab993f2d@kadam.mountain> (raw)
In-Reply-To: <20230823194202.2280957-1-harshit.m.mogalapalli@oracle.com>
On Wed, Aug 23, 2023 at 12:42:02PM -0700, Harshit Mogalapalli wrote:
> devm_clk_bulk_get_all() can return zero when no clocks are obtained.
> Passing zero to dev_err_probe() is a success which is incorrect.
>
> Fixes: 605efbf43813 ("i2c: qcom-cci: Use dev_err_probe in probe function")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> Only compile tested, found by static analysis with smatch.
>
> https://lore.kernel.org/all/CAA8EJprTOjbOy7N5+8NiJaNNhK+_btdUUFcpHKPkMuCZj5umMA@mail.gmail.com/
> ^^ I reported initially here, Dmitry suggested we need to fix it in a
> different patch.
>
> the Fixes commit used above pointed this bug, but the real fixes tag is this:
> Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
This has already been applied but, for future reference, you should have
gone with the real fixes tag instead of where the static checker started
complaining.
regards,
dan carpenter
next prev parent reply other threads:[~2023-09-05 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 19:42 [PATCH next] i2c: qcom-cci: Fix error checking in cci_probe() Harshit Mogalapalli
2023-08-24 9:10 ` Bryan O'Donoghue
2023-08-24 16:11 ` Andi Shyti
2023-08-25 20:07 ` Wolfram Sang
2023-09-05 9:10 ` Dan Carpenter [this message]
2023-09-05 9:24 ` Harshit Mogalapalli
2023-09-05 10:25 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e3acac-7d4f-43bd-bd55-5ae9ab993f2d@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liaochang1@huawei.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
--cc=vegard.nossum@oracle.com \
--cc=vkoul@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox