From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jochen Friedrich Subject: Re: build breakage from of i2c helper patch Date: Fri, 18 Apr 2008 14:27:52 +0200 Message-ID: <480893C8.6020300@scram.de> References: <48071778.2000405@scram.de> <20080417113703.0f24c578@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080417113703.0f24c578-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Jean Delvare Cc: "linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org list" , Stephen Rothwell , Paul Mackerras , Kumar Gala , Linux I2C List-Id: linux-i2c@vger.kernel.org Hi Jean, > (blind shot) Maybe this means that some code that is in i2c-core should > be moved to i2c-boardinfo instead? i2c-boardinfo is always built into > the kernel even when i2c-core is modular. unfortunately, i2c_new_device() tries to attach the module, so this function really needs full i2c-core functionality. I think the best way to fix this is to make the OF helpers def_tristate I2C, so it will be compiled as module if i2c-core is compiled as module, as well. I'll send an updated patch in a minute. Thanks, Jochen _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c