public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] eeprom: at24: use of_match_ptr()
Date: Wed, 22 Nov 2023 17:41:37 +0100	[thread overview]
Message-ID: <480fef02-09ed-9a32-d5bb-e7114381220c@axentia.se> (raw)
In-Reply-To: <20231122155916.38037-1-brgl@bgdev.pl>

Hi!

2023-11-22 at 16:59, Bartosz Golaszewski wrote:
> -		.of_match_table = at24_of_match,
> +		.of_match_table = of_match_ptr(at24_of_match),

If you do that, you will need to also add #ifdef CONFIG_OF around the
at24_of_match definition, of you'll trigger a warning about an unused
const variable (for some configs). I think.

Cheers,
Peter

  reply	other threads:[~2023-11-22 16:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 15:59 [PATCH] eeprom: at24: use of_match_ptr() Bartosz Golaszewski
2023-11-22 16:41 ` Peter Rosin [this message]
2023-11-22 16:57   ` Bartosz Golaszewski
2023-11-22 17:13     ` Peter Rosin
2023-11-22 17:26       ` Bartosz Golaszewski
2023-11-23  3:16 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480fef02-09ed-9a32-d5bb-e7114381220c@axentia.se \
    --to=peda@axentia.se \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox