From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jochen Friedrich Subject: Re: How to set device's platform_data field for OF-described I2C devices ? Date: Tue, 27 May 2008 17:35:15 +0200 Message-ID: <483C2A33.1020309@scram.de> References: <200805271348.06470.laurentp@cse-semaphore.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200805271348.06470.laurentp@cse-semaphore.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Laurent Pinchart Cc: linuxppc-dev@ozlabs.org, Linux I2C List-Id: linux-i2c@vger.kernel.org Hi Laurent, > I'm running into a small issue with the pca953x I2C GPIO driver. The driver > requires platform data (to set the GPIO base number among other information). > As the device is automatically instantiated from the OF device tree, I can't > find a way to add platform data in the process. Platform data really is a problem for devices loaded by OF device trees (see the discussion at http://ozlabs.org/pipermail/linuxppc-dev/2008-May/056728.html and in particular http://ozlabs.org/pipermail/linuxppc-dev/2008-May/056752.html). In case of this particular chip it might be feasible to support the new libgpio API to get a GPIO base number dynamically and use some defaults for the other platform data to enable the chip to be used without platform data. Otherwise, you could only bypass the OF bindings totally and add the device manually from platform code with the platform data filled in. > What's the best way to specify platform data for OF-described I2C devices ? This depends on the data. For example function pointers can't be described in the device tree, at all. Thanks, Jochen