From: Riku Voipio <riku.voipio-WgUW+8SLYMv1KXRcyAk9cg@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Linux I2C <i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: [PATCH 3/4] i2c: Use i2c_listener in driver f75375s
Date: Fri, 06 Jun 2008 13:21:23 +0300 [thread overview]
Message-ID: <48490FA3.8020702@movial.fi> (raw)
In-Reply-To: <20080605110659.3456fbe4-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
Jean Delvare wrote:
> I have already tested the latter, using i2c-stub + a dump of a F75375S
> chip. So if you can test the former (new-style) we cover the whole set
> of possibilities and that's alright :)
>
> Thanks,
>
I failed to get the patchset against Linux 2.6.26-rc5, and didn't have time
to fight:
> patch -p1 --dry-run <
../p2/\[PATCH_1_4\]_i2c__Introduce_i2c_listeners.txt
patching file include/linux/i2c.h
Hunk #2 succeeded at 94 (offset 1 line).
Hunk #3 succeeded at 185 (offset 1 line).
Hunk #4 succeeded at 203 (offset 1 line).
patching file drivers/i2c/i2c-core.c
Hunk #1 succeeded at 43 (offset 1 line).
Hunk #2 succeeded at 432 (offset 6 lines).
Hunk #3 succeeded at 463 (offset 6 lines).
Hunk #4 FAILED at 598.
Hunk #5 succeeded at 612 (offset 7 lines).
Hunk #6 succeeded at 796 (offset 12 lines).
Hunk #7 succeeded at 1240 (offset -35 lines).
1 out of 7 hunks FAILED -- saving rejects to file drivers/i2c/i2c-core.c.rej
However, none of the functions you touched are used in F75375S driver
with new-style loading path, so it would seem fine for me.
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-06-06 10:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 18:13 [PATCH 0/4] i2c: Introduce i2c listeners Jean Delvare
[not found] ` <20080604201334.19636f30-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-04 18:18 ` [PATCH 1/4] " Jean Delvare
2008-06-04 18:31 ` [PATCH 2/4] i2c: Convert the lm90 driver to a new-style i2c driver Jean Delvare
2008-06-04 18:33 ` [PATCH 3/4] i2c: Use i2c_listener in driver f75375s Jean Delvare
[not found] ` <20080604203322.472f8653-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-05 8:33 ` Riku Voipio
[not found] ` <4847A4E2.9040406-WgUW+8SLYMv1KXRcyAk9cg@public.gmane.org>
2008-06-05 9:06 ` Jean Delvare
[not found] ` <20080605110659.3456fbe4-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-06 10:21 ` Riku Voipio [this message]
[not found] ` <48490FA3.8020702-WgUW+8SLYMv1KXRcyAk9cg@public.gmane.org>
2008-06-06 11:38 ` Jean Delvare
2008-06-04 18:35 ` [PATCH 4/4] i2c: Use i2c_listener in driver lm75 Jean Delvare
2008-06-04 18:55 ` [PATCH 0/4] i2c: Introduce i2c listeners Jon Smirl
[not found] ` <9e4733910806041155n7551ac74lf29c8a32163ec09a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-04 19:28 ` Jon Smirl
[not found] ` <9e4733910806041228i330e145q439d3ee43494f4c4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-04 21:33 ` Jean Delvare
[not found] ` <20080604233335.13459512-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-04 23:11 ` Jon Smirl
[not found] ` <9e4733910806041611l41832e07p4f55424be0ef5ea0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-05 0:10 ` David Brownell
[not found] ` <200806041710.59338.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-06-05 0:42 ` Jon Smirl
[not found] ` <9e4733910806041742va67401en608c8c4b8c4c11b9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-05 2:21 ` David Brownell
[not found] ` <200806041921.26293.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-06-05 4:04 ` Jon Smirl
[not found] ` <9e4733910806042104l70cf8a30sc6329b1c3016c879-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-05 8:18 ` David Brownell
[not found] ` <200806050118.23706.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-06-05 14:55 ` Jon Smirl
[not found] ` <9e4733910806050755n3835d20xfc4d018c2222d5d3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-05 17:00 ` Jean Delvare
[not found] ` <20080605190034.16f06604-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-05 17:34 ` Jon Smirl
[not found] ` <9e4733910806051034k2e40082focaaa03b124fcd4ad-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-05 18:29 ` Jean Delvare
2008-06-05 8:49 ` Jean Delvare
[not found] ` <20080605104914.2dd622b2-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-05 14:30 ` Jon Smirl
2008-06-05 8:38 ` Jean Delvare
2008-06-05 9:05 ` Jean Delvare
[not found] ` <20080605110502.76f0f606-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-05 14:59 ` Jon Smirl
2008-06-05 0:03 ` Trent Piepho
[not found] ` <Pine.LNX.4.58.0806041638080.10290-13q4cmjDBaTP3RPoUHIrnuTW4wlIGRCZ@public.gmane.org>
2008-06-05 0:27 ` David Brownell
[not found] ` <200806041727.51746.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-06-05 0:40 ` Trent Piepho
[not found] ` <Pine.LNX.4.58.0806041731250.10290-13q4cmjDBaTP3RPoUHIrnuTW4wlIGRCZ@public.gmane.org>
2008-06-05 2:14 ` David Brownell
[not found] ` <200806041914.27291.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-06-05 7:08 ` Trent Piepho
[not found] ` <Pine.LNX.4.58.0806042349251.10290-13q4cmjDBaTP3RPoUHIrnuTW4wlIGRCZ@public.gmane.org>
2008-06-05 8:15 ` David Brownell
2008-06-05 8:16 ` Jean Delvare
2008-06-05 0:45 ` Jon Smirl
2008-06-04 21:12 ` Jean Delvare
2008-06-06 2:47 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48490FA3.8020702@movial.fi \
--to=riku.voipio-wguw+8slymv1kxrcyak9cg@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox