* [PATCH] [OF] of_i2c: fix request_module() usage
@ 2008-06-12 7:44 maximilian attems
[not found] ` <1213256647-22708-1-git-send-email-max-U9r9yeDMy7A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: maximilian attems @ 2008-06-12 7:44 UTC (permalink / raw)
To: Jochen Friedrich, Paul Mackerras
Cc: maximilian attems, davem-fT/PcQaiUtIeIZ0/mPfg9Q,
i2c-GZX6beZjE8VD60Wz+7aTrA
similar to 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b,
the file the info.type value is read from could be broken.
Signed-off-by: maximilian attems <max-U9r9yeDMy7A@public.gmane.org>
Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
---
drivers/of/of_i2c.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index b2ccdcb..117de8b 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -100,7 +100,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
info.addr = *addr;
- request_module(info.type);
+ request_module("%s", info.type);
result = i2c_new_device(adap, &info);
if (result == NULL) {
--
1.5.5.3
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [OF] of_i2c: fix request_module() usage
[not found] ` <1213256647-22708-1-git-send-email-max-U9r9yeDMy7A@public.gmane.org>
@ 2008-06-28 11:28 ` Jochen Friedrich
0 siblings, 0 replies; 2+ messages in thread
From: Jochen Friedrich @ 2008-06-28 11:28 UTC (permalink / raw)
To: maximilian attems
Cc: Paul Mackerras, davem-fT/PcQaiUtIeIZ0/mPfg9Q,
i2c-GZX6beZjE8VD60Wz+7aTrA
maximilian attems schrieb:
> similar to 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b,
> the file the info.type value is read from could be broken.
>
> Signed-off-by: maximilian attems <max-U9r9yeDMy7A@public.gmane.org>
> Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Acked-by: Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org>
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-28 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-12 7:44 [PATCH] [OF] of_i2c: fix request_module() usage maximilian attems
[not found] ` <1213256647-22708-1-git-send-email-max-U9r9yeDMy7A@public.gmane.org>
2008-06-28 11:28 ` Jochen Friedrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox