From: Jonathan Cameron <jic23@cam.ac.uk>
To: eric miao <eric.y.miao@gmail.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
Ben Dooks <ben-linux@fluff.org>,
i2c@lm-sensors.org
Subject: Re: [i2c] [PATCH 1/1] I2C pxa fast mode (400khz) support
Date: Sun, 13 Jul 2008 16:40:27 +0100 [thread overview]
Message-ID: <487A21EB.9050304@cam.ac.uk> (raw)
In-Reply-To: <f17812d70807100648m13896650xdafab02b5dc448ec@mail.gmail.com>
eric miao wrote:
> On Thu, Jul 10, 2008 at 9:31 PM, Ben Dooks <ben-linux@fluff.org> wrote:
>> On Wed, Jul 02, 2008 at 04:26:40PM +0100, Jonathan Cameron wrote:
>>> Add fast_mode option to i2c_pxa_platform_data and use it to set the ICR_FM bit
>>> appropriately when i2c_pxa_reset is called. Parameter called fast_mode rather
>>> than frequency as this driver is also used for the i2c_pxa_pwr bus which has
>>> different normal and fast frequencies.
>>>
>>> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
>> Unfortuantely due to the problem of all the registers in
>> one place, this really will need to be applied by RMK. However
>> due to the current amount of work in the PXA tree, and the
>> number of patches he is carrying for merging this is going
>> to be too late for this kernel merge.
>>
>
> Actually, this round of separation work of the pxa-regs.h has been
> done several weeks ago, so I don't see this patch is likely to
> cause any merge conflict.
>
> But Russell is going to freeze the pxa branch, I see little chance
> this be fixed quickly and get into :(
>
Dear all, thanks for the comments.
I'll switch the use_pio and fast_mode flags to bit fields and resend
when next kernel merge begins.
As I'm maintaining rather a lot of platform specific stuff anyway for
my use, one more won't do any harm for a few weeks!
Cheers,
--
Jonathan Cameron
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2008-07-13 15:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 15:26 [PATCH 1/1] I2C pxa fast mode (400khz) support Jonathan Cameron
[not found] ` <486B9E30.80806-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2008-07-03 2:00 ` Eric Miao
2008-07-10 13:29 ` [i2c] " Ben Dooks
[not found] ` <20080710132956.GG30539-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-07-12 2:20 ` David Brownell
[not found] ` <200807111920.29739.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-07-12 21:02 ` Troy Kisky
[not found] ` <48791BF8.8080500-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2008-07-12 21:35 ` David Brownell
2008-07-09 16:48 ` Jean Delvare
2008-07-10 13:31 ` [i2c] " Ben Dooks
[not found] ` <20080710133150.GH30539-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-07-10 13:48 ` eric miao
2008-07-13 15:40 ` Jonathan Cameron [this message]
2008-07-15 9:43 ` [i2c] " Ben Dooks
2008-07-15 9:54 ` Russell King - ARM Linux
2008-07-15 10:37 ` Uwe Kleine-König
2008-07-15 10:51 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487A21EB.9050304@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=ben-linux@fluff.org \
--cc=eric.y.miao@gmail.com \
--cc=i2c@lm-sensors.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox