From: Ivo Manca <pinkel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
"Mark M. Hoffman"
<mhoffman-xQSgfq/1h4JiLUuM0BA3LQ@public.gmane.org>
Cc: Hans de Goede <j.w.r.degoede-fbo2DhPpy/Q@public.gmane.org>,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: [PATCH 03/03] i2c-i801: Fix minor style issues
Date: Wed, 23 Jul 2008 18:57:37 +0200 [thread overview]
Message-ID: <48876301.9020903@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
This patch fixes minor style issues warned about by checkPatch
Signed-off-by: Ivo Manca <pinkel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
[PATCH 00/03] i2c-i801: Add basic interrupt support
[-- Attachment #2: patch3.diff --]
[-- Type: text/plain, Size: 1354 bytes --]
--- __new 2008-07-23 10:51:28.000000000 +0200
+++ _new 2008-07-23 10:53:06.000000000 +0200
@@ -381,9 +381,8 @@ static int i801_block_transaction_byte_b
do {
msleep(1);
temp = inb_p(SMBHSTSTS);
- }
- while ((!(temp & SMBHSTSTS_BYTE_DONE))
- && (timeout++ < MAX_TIMEOUT));
+ } while ((!(temp & SMBHSTSTS_BYTE_DONE))
+ && (timeout++ < MAX_TIMEOUT));
/* If the SMBus is still busy, we give up */
if (timeout >= MAX_TIMEOUT) {
@@ -502,7 +501,7 @@ static int i801_block_transaction(union
}
/* Return -1 on error. */
-static s32 i801_access(struct i2c_adapter * adap, u16 addr,
+static s32 i801_access(struct i2c_adapter *adap, u16 addr,
unsigned short flags, char read_write, u8 command,
int size, union i2c_smbus_data * data)
{
@@ -574,7 +573,7 @@ static s32 i801_access(struct i2c_adapte
else
outb_p(inb_p(SMBAUXCTL) & (~SMBAUXCTL_CRC), SMBAUXCTL);
- if(block)
+ if (block)
ret = i801_block_transaction(data, read_write, size, hwpec);
else
ret = i801_transaction(xact | ENABLE_INT9);
@@ -586,9 +585,9 @@ static s32 i801_access(struct i2c_adapte
outb_p(inb_p(SMBAUXCTL) & ~(SMBAUXCTL_CRC | SMBAUXCTL_E32B),
SMBAUXCTL);
- if(block)
+ if (block)
return ret;
- if(ret)
+ if (ret)
return -1;
if ((read_write == I2C_SMBUS_WRITE) || (xact == I801_QUICK))
return 0;
[-- Attachment #3: Type: text/plain, Size: 157 bytes --]
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next reply other threads:[~2008-07-23 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 16:57 Ivo Manca [this message]
[not found] ` <48876301.9020903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-08-12 8:27 ` [PATCH 03/03] i2c-i801: Fix minor style issues Jean Delvare
[not found] ` <20080812102711.6f8b178a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-08-12 20:50 ` Ivo Manca
[not found] ` <48A1F7AF.4030707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-08-13 7:09 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48876301.9020903@gmail.com \
--to=pinkel-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=j.w.r.degoede-fbo2DhPpy/Q@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=mhoffman-xQSgfq/1h4JiLUuM0BA3LQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox