Re: [PATCH] i2c: don't autograb i2c-pca-isa

[Rene Herman <rene.herman-cENuUygGYd//D1n+0JDH9g@public.gmane.org>]

On 09-08-08 15:28, Jean Delvare wrote:

> On Fri, 08 Aug 2008 19:19:17 +0200, Rene Herman wrote:

>> Grabbing ISA bus resources without anything or anyone telling us we
>> should can break boot on randconfig/allyesconfig builds by keeping
>> resources that are in fact owned by different hardware busy and does
>> as reported by Ingo Molnar.
> 
> I don't think it makes much sense to boot randomconfig kernels. The
> i2c-pca-isa driver is for rare hardware, most people will not use it
> and certainly won't build it into the kernel. So I don't think there
> really is a problem in practice here. That being said...

Ingo actually hit this -- i2c-pca-isa "broke" his e1000 by grabbing 
IRQ10. He does randonfig builds for testing purposes (which a little 
while ago caught a dumb yet very old bug in an ALSA ISA driver which 
impressed the usefulness of such on me...)

> I am curious how many users of this driver are left. Maybe it's time to
> get rid of it.

I rather expect the number is 0 but unless it's a maintenance burden I'd 
say to keep it around if only as a "see, this is how simple it gets" 
sort of thing.

(not that the other drivers in there are wildly complex it seems upon 
looking, so, well, what do I know)

>> +static int __devinit pca_isa_match(struct device *dev, unsigned int id)
>> +{
>> +	int match = base != 0;
>> +
>> +	if (match) {
>> +		if (irq == -1)
>> +			dev_warn(dev, "using poling mode (specify irq)\n");
> 
> Spelling: polling.

Argh.

> Other than that, this looks OK. I'll queue this for 2.6.28.

Thanks.

Rene.

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c