* [PATCH 12/33] i2c: Make static
[not found] ` <493EA286.7080500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2008-12-09 18:41 ` Roel Kluin
2008-12-09 19:04 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2008-12-09 18:41 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, lkml
Sparse asked whether these could be static.
Signed-off-by: Roel Kluin <roel.kluin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/i2c/i2c-core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index c6a63f4..1049615 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1699,7 +1699,8 @@ EXPORT_SYMBOL(i2c_smbus_write_word_data);
* This executes the SMBus "process call" protocol, returning negative errno
* else a 16-bit unsigned "word" received from the device.
*/
-s32 i2c_smbus_process_call(struct i2c_client *client, u8 command, u16 value)
+static s32 i2c_smbus_process_call(struct i2c_client *client, u8 command,
+ u16 value)
{
union i2c_smbus_data data;
int status;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 12/33] i2c: Make static
2008-12-09 18:41 ` [PATCH 12/33] i2c: Make static Roel Kluin
@ 2008-12-09 19:04 ` Jean Delvare
[not found] ` <20081209200409.17fac29f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2008-12-09 19:04 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-i2c, lkml
On Tue, 09 Dec 2008 19:41:20 +0100, Roel Kluin wrote:
> Sparse asked whether these could be static.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/i2c/i2c-core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index c6a63f4..1049615 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1699,7 +1699,8 @@ EXPORT_SYMBOL(i2c_smbus_write_word_data);
> * This executes the SMBus "process call" protocol, returning negative errno
> * else a 16-bit unsigned "word" received from the device.
> */
> -s32 i2c_smbus_process_call(struct i2c_client *client, u8 command, u16 value)
> +static s32 i2c_smbus_process_call(struct i2c_client *client, u8 command,
> + u16 value)
> {
> union i2c_smbus_data data;
> int status;
Nack:
drivers/i2c/i2c-core.c:EXPORT_SYMBOL(i2c_smbus_process_call);
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 12/33] i2c: Make static
[not found] ` <20081209200409.17fac29f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
@ 2008-12-09 22:53 ` roel kluin
0 siblings, 0 replies; 3+ messages in thread
From: roel kluin @ 2008-12-09 22:53 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, lkml
> Nack:
>
> drivers/i2c/i2c-core.c:EXPORT_SYMBOL(i2c_smbus_process_call);
>
> --
> Jean Delvare
>
Again thanks for reporting, fortunately it appears that this only occurred
in a few other patches.
Roel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-09 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <493EA286.7080500@gmail.com>
[not found] ` <493EA286.7080500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-12-09 18:41 ` [PATCH 12/33] i2c: Make static Roel Kluin
2008-12-09 19:04 ` Jean Delvare
[not found] ` <20081209200409.17fac29f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-12-09 22:53 ` roel kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox