From: Timur Tabi <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Dynamically-allocated i2c_device_id vs MODULE_DEVICE_TABLE
Date: Fri, 23 Jan 2009 15:03:19 -0600 [thread overview]
Message-ID: <497A3097.1030808@freescale.com> (raw)
I currently have this in my code:
static const struct i2c_device_id cs4270_id[] = {
{"cs4270", 0},
{}
};
MODULE_DEVICE_TABLE(i2c, cs4270_id);
static struct i2c_driver cs4270_i2c_driver = {
.driver = {
.name = "cs4270",
.owner = THIS_MODULE,
},
.id_table = cs4270_id,
.probe = cs4270_i2c_probe,
.remove = cs4270_i2c_remove,
};
ret = i2c_add_driver(&cs4270_i2c_driver);
I would like to use the i2c_device_id.driver_data variable to pass private data
to my cs4270_i2c_probe() function. So it will look like this:
socdev = kmalloc(...);
c24270_id.driver_data = socdev;
i2c_add_driver(&cs4270_i2c_driver);
And then in my cs4270_i2c_probe(), I would do this:
static int cs4270_i2c_probe(struct i2c_client *i2c_client,
const struct i2c_device_id *id)
{
struct X *socdev = (struct X *) id->driver_data.
The problem I'm having is the MODULE_DEVICE_TABLE. What I really should be
doing is this:
socdev = kmalloc(...);
struct i2c_driver *cs4270_i2c_driver = kmalloc(...);
struct i2c_device_id *cs4270_id = kmalloc(...);
cs4270_i2c_driver->id_table = cs4270_id;
c24270_id->driver_data = socdev;
i2c_add_driver(cs4270_i2c_driver);
But if I do this, then I can't use MODULE_DEVICE_TABLE. So I have two questions:
1) What happens if I don't use MODULE_DEVICE_TABLE to identify my I2C ID table?
2) Is there a way to mimic the behavior of MODULE_DEVICE_TABLE on a
dynamically-created ID table?
--
Timur Tabi
Linux kernel developer at Freescale
next reply other threads:[~2009-01-23 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 21:03 Timur Tabi [this message]
[not found] ` <497A3097.1030808-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2009-01-23 22:26 ` Dynamically-allocated i2c_device_id vs MODULE_DEVICE_TABLE Jon Smirl
2009-01-24 1:28 ` Mark Brown
[not found] ` <20090124012817.GA31775-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-01-24 2:23 ` Timur Tabi
[not found] ` <497A7BA4.2080908-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2009-01-24 11:39 ` Mark Brown
2009-01-24 16:50 ` Ben Dooks
[not found] ` <20090124165040.GL8032-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-01-26 18:06 ` Timur Tabi
[not found] ` <ed82fe3e0901261006u2223ccb3n5d7b3be9a85df7c7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-26 19:16 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497A3097.1030808@freescale.com \
--to=timur-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox