From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Hans Berglund <hb-wBUg6WsUcUgXWF+eFR7m5Q@public.gmane.org>,
Jonas Bonn <jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT
Date: Tue, 16 Aug 2011 21:42:06 +0200 [thread overview]
Message-ID: <4991605.b7BYCfYE3S@wuerfel> (raw)
In-Reply-To: <CAMuHMdUk_xTwGbhG0MHkS-8rkF76b1fg193pPcs+9MVyB-qHQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tuesday 16 August 2011 21:14:42 Geert Uytterhoeven wrote:
> >> config I2C_ELEKTOR
> >> tristate "Elektor ISA card"
> >> - depends on ISA && BROKEN_ON_SMP
> >> + depends on ISA && HAS_IOPORT && BROKEN_ON_SMP
> >> select I2C_ALGOPCF
> >> help
> >> This supports the PCF8584 ISA bus I2C adapter. Say Y if you own
> >
> > How can ISA be set if HAS_IOPORT is not? This shouldn't be allowed.
>
> It's always been like that. With CONFIG_ISA, we have inb() and friends. But not
> ioport_map(), which was introduced more recently.
Right. BTW, I'd really like to change that once I've picked up and fixed the
use of inb() in 8250.c. I think we should change CONFIG_HAS_IOPORT to mean
that inb(), ioport_resource and /proc/ioports are available, while a new
CONFIG_HAS_IOPORT_MAP can then replace the current CONFIG_HAS_IOPORT symbol.
Arnd
next prev parent reply other threads:[~2011-08-16 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 11:20 [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT Geert Uytterhoeven
[not found] ` <1312802446-19154-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2011-08-16 17:50 ` Jean Delvare
[not found] ` <20110816195033.014f302b-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-08-16 19:14 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUk_xTwGbhG0MHkS-8rkF76b1fg193pPcs+9MVyB-qHQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-16 19:42 ` Arnd Bergmann [this message]
2011-08-17 9:39 ` Jean Delvare
[not found] ` <20110817113910.47dc819f-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-08-29 7:48 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVX_p4Q1E+-Q1HOjUO-Zhbsv_uji2qqGZipii=qY0hHWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-29 7:55 ` Jean Delvare
[not found] ` <20110829095530.789ec9ea-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-08-29 8:13 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4991605.b7BYCfYE3S@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=hb-wBUg6WsUcUgXWF+eFR7m5Q@public.gmane.org \
--cc=jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).