From: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Delvare,
Jean " <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH] assign a default class to MPC adapter
Date: Thu, 16 Apr 2009 12:55:46 +0200 [thread overview]
Message-ID: <49E70EB2.60106@gmx.de> (raw)
In-Reply-To: <20090416092012.GB3052-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Wolfram Sang said the following:
> On Thu, Apr 16, 2009 at 11:06:01AM +0200, Michael Lawnick wrote:
>> For MPC adapter there is no class assigned as it is done in other
>> adapters. This way no new-style client will ever be instantiated. There
>> should be at least a default class assignment.
>
> Please have a loot at 618b26d52843c0f85b8eb143cf2695d7f6fd072d
> Therefore, NACK.
AFAICS, this patch related to 2.6.26 and i2c code has changed since.
In i2c-core.c@i2c_detect there is now a check whether the driver is
legacy, if it is the function is left and driver initialization handled
in another way. This was not the case when the patch of Wolfgang
Grandegger was applied.
I still don't think it makes much sense to include code (i2c-mpc.c) that
has no function by default - what in fact is the case since last change
of i2c-core.c
--
Kind Regards,
Michael
next prev parent reply other threads:[~2009-04-16 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 9:06 [PATCH] assign a default class to MPC adapter Michael Lawnick
[not found] ` <49E6F4F9.3060705-Mmb7MZpHnFY@public.gmane.org>
2009-04-16 9:20 ` Wolfram Sang
[not found] ` <20090416092012.GB3052-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-04-16 10:55 ` Michael Lawnick [this message]
2009-04-16 11:01 ` Michael Lawnick
[not found] ` <49E7101E.6070806-Mmb7MZpHnFY@public.gmane.org>
2009-04-16 11:47 ` Wolfram Sang
[not found] ` <20090416114701.GD3052-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-04-16 13:36 ` Michael Lawnick
[not found] ` <49E7344C.2060704-Mmb7MZpHnFY@public.gmane.org>
2009-04-16 13:55 ` Jean Delvare
[not found] ` <49E82270.4030509@gmx.de>
[not found] ` <49E82270.4030509-Mmb7MZpHnFY@public.gmane.org>
2009-04-17 7:33 ` Jean Delvare
[not found] ` <20090417093356.79f38e40-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-04-17 7:46 ` Wolfram Sang
2009-04-16 14:05 ` Wolfram Sang
2009-04-21 6:47 ` Michael Lawnick
[not found] ` <49ED6C0D.2060607-Mmb7MZpHnFY@public.gmane.org>
2009-04-21 7:13 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E70EB2.60106@gmx.de \
--to=ml.lawnick-mmb7mzphnfy@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox