Re: [PATCH] assign a default class to MPC adapter

[Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>]

Michael Lawnick wrote:
> Wolfram Sang said the following:
>>> Could you please elaborate?
>> Instead of probing you specify the devices on the i2c-bus in the dts. Example
>> for the pcm032 looks like this (from the kernel-tree):
>>
>> i2c@3d40 {
>> 	#address-cells = <1>;
>> 	#size-cells = <0>;
>> 	compatible = "fsl,mpc5200b-i2c","fsl,mpc5200-i2c","fsl-i2c";
>> 	reg = <0x3d40 0x40>;
>> 	interrupts = <2 16 0>;
>> 	fsl5200-clocking;
>>
>> 	rtc@51 {
>> 		compatible = "nxp,pcf8563";
>> 		reg = <0x51>;
>> 	};
>> 	eeprom@52 {
>> 		compatible = "at24,24c32";
>> 		reg = <0x52>;
>> 	};
>> };
>>
>> Boards which relied on probing need to have such child nodes added.
> 
> This entry forces the sysFs basic entries, but instantiation of
> _new-style_ drivers still fails, at least on my system.

Could you switch I2C debugging on and check the transfers to the device?
Is the address correct? What DTS node do you use? You could compare it
with a kernel with your patch applied and using probing.

> I now proposed a patch for loading the class parameter of the adapter
> from device tree.(--><49ED6AD3.2060808-Mmb7MZpHnFY@public.gmane.org>) and hope to get an ACK.

What kernel version do you use?

Wolfgang.