public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Delvare,
	Jean " <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [Patch v2] MPC Adapter: read class attribute from device tree
Date: Wed, 22 Apr 2009 09:45:22 +0200	[thread overview]
Message-ID: <49EECB12.9000106@grandegger.com> (raw)
In-Reply-To: <49EEC50A.4050707-Mmb7MZpHnFY@public.gmane.org>

Michael Lawnick wrote:
> For MPC adapter there is no class assigned as it is done in other
> adapters. This way no new-style client will ever be instantiated, if not
> noted in device tree or forced. With this patch class assignment is read
> from device tree.
> If class assignment is not set in device tree .class stays default (0)
> 
> Necessary device tree entry:
> linux,i2c-class = <1>; /* I2C_CLASS_HWMON (iic.h) */
> 
> Based on kernel 2.6.29
> 
> Signed-off-by: Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Sang, Wolfram <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>

Please document the new device tree binding in
"Documentation/powerpc/dts-bindings/fsl/i2c.txt", send a CC to
"devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org", use an up-to-date version of the
linux-2.6 tree (there are some patches for i2c-mpc.c pending) and fix
the coding style issues.

Wolfgang.

  parent reply	other threads:[~2009-04-22  7:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22  7:19 [Patch v2] MPC Adapter: read class attribute from device tree Michael Lawnick
     [not found] ` <49EEC50A.4050707-Mmb7MZpHnFY@public.gmane.org>
2009-04-22  7:34   ` Jean Delvare
2009-04-22  7:45   ` Wolfgang Grandegger [this message]
2009-04-22 14:23   ` Jon Smirl
     [not found]     ` <9e4733910904220723u68392662vb854188c1dec02fd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-22 18:32       ` Wolfgang Grandegger
     [not found]         ` <49EF62AF.5070004-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-04-22 19:52           ` Jon Smirl
2009-04-23  6:48       ` Michael Lawnick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EECB12.9000106@grandegger.com \
    --to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ml.lawnick-Mmb7MZpHnFY@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox