From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
linux-amlogic@lists.infradead.org
Subject: [PATCH v4 09/10] i2c: meson: remove meson_i2c_write_tokens
Date: Tue, 14 Mar 2017 22:51:49 +0100 [thread overview]
Message-ID: <49e666dd-9fda-6380-26d7-11f76be47f1f@gmail.com> (raw)
In-Reply-To: <1a2ecdc8-a326-a7a7-22ec-658fd147daf4@gmail.com>
meson_i2c_write_tokens is always called directly after
meson_i2c_prepare_xfer (and only then). So we can simplify the code by
removing meson_i2c_write_tokens and moving the two statements of
meson_i2c_write_tokens to the end of meson_i2c_prepare_xfer.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- rebased
v3:
- no changes
v4:
- no changes
---
drivers/i2c/busses/i2c-meson.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 6c873ed8..23f25efa 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -123,12 +123,6 @@ static void meson_i2c_add_token(struct meson_i2c *i2c, int token)
i2c->num_tokens++;
}
-static void meson_i2c_write_tokens(struct meson_i2c *i2c)
-{
- writel(i2c->tokens[0], i2c->regs + REG_TOK_LIST0);
- writel(i2c->tokens[1], i2c->regs + REG_TOK_LIST1);
-}
-
static void meson_i2c_set_clk_div(struct meson_i2c *i2c, unsigned int freq)
{
unsigned long clk_rate = clk_get_rate(i2c->clk);
@@ -207,6 +201,9 @@ static void meson_i2c_prepare_xfer(struct meson_i2c *i2c)
if (i2c->last && i2c->pos + i2c->count >= i2c->msg->len)
meson_i2c_add_token(i2c, TOKEN_STOP);
+
+ writel(i2c->tokens[0], i2c->regs + REG_TOK_LIST0);
+ writel(i2c->tokens[1], i2c->regs + REG_TOK_LIST1);
}
static irqreturn_t meson_i2c_irq(int irqno, void *dev_id)
@@ -272,12 +269,10 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id)
}
out:
- if (i2c->state != STATE_IDLE) {
+ if (i2c->state != STATE_IDLE)
/* Restart the processing */
- meson_i2c_write_tokens(i2c);
meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START,
REG_CTRL_START);
- }
spin_unlock(&i2c->lock);
@@ -318,7 +313,6 @@ static int meson_i2c_xfer_msg(struct meson_i2c *i2c, struct i2c_msg *msg,
i2c->state = (msg->flags & I2C_M_RD) ? STATE_READ : STATE_WRITE;
meson_i2c_prepare_xfer(i2c);
- meson_i2c_write_tokens(i2c);
reinit_completion(&i2c->done);
/* Start the transfer */
--
2.12.0
next prev parent reply other threads:[~2017-03-14 21:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 21:42 [PATCH v4 00/10] i2c: meson: series with improvements Heiner Kallweit
2017-03-14 21:50 ` [PATCH v4 01/10] i2c: meson: use min instead of min_t where min_t isn't needed Heiner Kallweit
2017-03-14 21:50 ` [PATCH v4 02/10] i2c: meson: remove member irq from struct meson_i2c Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 04/10] i2c: meson: use i2c core for DT clock-frequency parsing Heiner Kallweit
2017-03-23 20:33 ` Wolfram Sang
2017-03-24 6:47 ` Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 05/10] i2c: meson: use full 12 bits for clock divider Heiner Kallweit
2017-03-23 20:34 ` Wolfram Sang
2017-03-24 6:49 ` Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 06/10] i2c: meson: remove variable count from meson_i2c_xfer Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 07/10] i2c: meson: improve interrupt handler and detect spurious interrupts Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 08/10] i2c: meson: don't create separate token chain just for the stop command Heiner Kallweit
2017-03-14 21:51 ` Heiner Kallweit [this message]
2017-03-14 21:51 ` [PATCH v4 10/10] i2c: meson: improve and simplify interrupt handler Heiner Kallweit
2017-03-14 21:53 ` [PATCH v4 03/10] i2c: meson: set clock divider in probe instead of setting it for each transfer Heiner Kallweit
2017-03-23 20:31 ` Wolfram Sang
2017-03-24 6:45 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e666dd-9fda-6380-26d7-11f76be47f1f@gmail.com \
--to=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).