linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org>
To: Michael Trimarchi <michael-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org>
Cc: bruno-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	trimarchi-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org
Subject: Re: [RFC] Fix stuck on cpm-i2c driver
Date: Sat, 20 Jun 2009 16:40:51 +0200	[thread overview]
Message-ID: <4A3CF4F3.4030002@scram.de> (raw)
In-Reply-To: <20090619125002.GA17067-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org>

Hi Michael,

> This happen because though the wait_event_interruptible_timeout takes the
> signals into account, the driver does not handle them.
> We propose to change the wait_event_interruptible_timeout with
> wait_event_timeout, leaving the signals to be handled in other points
> on the upper layers.

Makes sense. I2C transactions better shouldn't be interrupted or
data loss might happen.

> Signed-off-by: Bruno Morelli <bruno-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org>
> Signed-off-by: Michael Trimarchi <michael-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org>

Acked-by: Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org>

Thanks,
Jochen

      parent reply	other threads:[~2009-06-20 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 12:50 [RFC] Fix stuck on cpm-i2c driver Michael Trimarchi
     [not found] ` <20090619125002.GA17067-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org>
2009-06-20 14:40   ` Jochen Friedrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A3CF4F3.4030002@scram.de \
    --to=jochen-nigtfmg+po8@public.gmane.org \
    --cc=bruno-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=michael-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org \
    --cc=trimarchi-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).