RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

Woodruff, Richard
2009-10-14T13:25:42Z

> > >> /* I2C WE wakeup enable register */
> > >> -#define OMAP_I2C_WE_XDR_WE (1 << 14) /* TX drain wakup */
> > >> +#define OMAP_I2C_WE_XDR_WE (1 << 14) /* TX drain wakeup */
> > >> #define OMAP_I2C_WE_RDR_WE (1 << 13) /* RX drain wakeup */
> > >> +#define OMAP_I2C_WE_ROVR_WE (1 << 11) /* RX overflow wakeup */
> > >> +#define OMAP_I2C_WE_XUDF_WE (1 << 10) /* TX underflow wakeup */
> > >
> > > These bits are not documented in OMAP3430, they are reserved. How can
> > they be used?
> >
> > Hmm, that's a valid point. I will have to check if I can find more info on
> > the background of this patch.
>
> AFAIK, these bits have been introduced in OMAP3630 as it has a new IP block
> for I2C. But these bits are reserved bits for OMAP3430.

Couple notes:
- IP block is updated but it is not new. These should just be some reserved bits converted. New bits expand wakeup capability and enhance FIFO operation with DMA.

- Driver for a while supported OMAP1/2420 style I2C and OMAP2430/3/4 style I2C. Definitions between broad class drivers are different. The interrupt handler is easiest to see this. This is not so relevant to above bits but is good to keep in mind.

Regards,
Richard W.